Hoa Nguyen has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/33035 )

Change subject: base: Tag API methods in flags.hh
......................................................................

base: Tag API methods in flags.hh

Change-Id: I12eb94b43e190ee46f82fba7d2a3ef6c29fdee80
Signed-off-by: Hoa Nguyen <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33035
Maintainer: Bobby R. Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
---
M src/base/flags.hh
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/flags.hh b/src/base/flags.hh
index 0b0a803..c9525fa 100644
--- a/src/base/flags.hh
+++ b/src/base/flags.hh
@@ -37,11 +37,23 @@

   public:
     typedef T Type;
+
+    /**
+     * @ingroup api_flags
+     * @{
+     */
     Flags() : _flags(0) {}
     Flags(Type flags) : _flags(flags) {}
+    /** @} */ // end of api_flags

+    /**
+     * @ingroup api_flags
+     */
     operator const Type() const { return _flags; }

+    /**
+     * @ingroup api_flags
+     */
     template <typename U>
     const Flags<T> &
     operator=(const Flags<U> &flags)
@@ -50,6 +62,9 @@
         return *this;
     }

+    /**
+     * @ingroup api_flags
+     */
     const Flags<T> &
     operator=(T flags)
     {
@@ -57,6 +72,10 @@
         return *this;
     }

+    /**
+     * @ingroup api_flags
+     * @{
+     */
     bool isSet() const { return _flags; }
     bool isSet(Type flags) const { return (_flags & flags); }
     bool allSet() const { return !(~_flags); }
@@ -72,6 +91,7 @@
     {
         _flags = (_flags & ~mask) | (flags & mask);
     }
+    /** @} */ // end of api_flags
 };

 #endif // __BASE_FLAGS_HH__

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/33035
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I12eb94b43e190ee46f82fba7d2a3ef6c29fdee80
Gerrit-Change-Number: 33035
Gerrit-PatchSet: 2
Gerrit-Owner: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to