Srikant Bharadwaj has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34257 )
Change subject: mem-garnet: Fix default value of network bridge
......................................................................
mem-garnet: Fix default value of network bridge
Initializing the network bridge with NULL causes it to have
an class error when instatiating a link. The bridge is only
needed whne either a CDC or SerDes is enabled. This is handled
later during construction of the GarnetLink.
Change-Id: If19a21a6d9bf49449b9c390467d08d3422ae991a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34257
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/network/garnet2.0/GarnetLink.py
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/network/garnet2.0/GarnetLink.py
b/src/mem/ruby/network/garnet2.0/GarnetLink.py
index 33a3d31..9f7fe8b 100644
--- a/src/mem/ruby/network/garnet2.0/GarnetLink.py
+++ b/src/mem/ruby/network/garnet2.0/GarnetLink.py
@@ -140,14 +140,14 @@
# The network bridge encapsulates both the CDC and Ser-Des
# units in HeteroGarnet. This is automatically enabled when
# either CDC or Ser-Des is enabled.
- ext_net_bridge = VectorParam.NetworkBridge(NULL,
+ ext_net_bridge = VectorParam.NetworkBridge([],
"Network Bridge at external end")
- ext_cred_bridge = VectorParam.NetworkBridge(NULL,
+ ext_cred_bridge = VectorParam.NetworkBridge([],
"Credit Bridge at external end")
- int_net_bridge = VectorParam.NetworkBridge(NULL,
+ int_net_bridge = VectorParam.NetworkBridge([],
"Network Bridge at internal end")
- int_cred_bridge = VectorParam.NetworkBridge(NULL,
- "Credit Bridge at intternal end")
+ int_cred_bridge = VectorParam.NetworkBridge([],
+ "Credit Bridge at internal end")
width = Param.UInt32(Parent.ni_flit_size,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34257
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If19a21a6d9bf49449b9c390467d08d3422ae991a
Gerrit-Change-Number: 34257
Gerrit-PatchSet: 3
Gerrit-Owner: Srikant Bharadwaj <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: Srikant Bharadwaj <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
