Jason Lowe-Power has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34595 )
Change subject: configs: Add special case in MemConfig
......................................................................
configs: Add special case in MemConfig
SimpleMemory doesn't implement a full MemCtrl interface. Thus, like the
NVM and HMC memories, we need to add a special case to MemConfig.py. The
--mem-type command line option now works for SimpleMemory and all of the
DRAM interfaces (it does not work for the NVM interfaces, though).
Issue-on: https://gem5.atlassian.net/browse/GEM5-777
Change-Id: I6d60649215be324bdd2a104b1976752f936c960e
Signed-off-by: Jason Lowe-Power <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34595
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M configs/common/MemConfig.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
kokoro: Regressions pass
diff --git a/configs/common/MemConfig.py b/configs/common/MemConfig.py
index 941b381..8221f85 100644
--- a/configs/common/MemConfig.py
+++ b/configs/common/MemConfig.py
@@ -227,11 +227,15 @@
mem_ctrl = m5.objects.MemCtrl(min_writes_per_switch =
8,
static_backend_latency
= '4ns',
static_frontend_latency
= '4ns')
+ elif opt_mem_type == "SimpleMemory":
+ mem_ctrl = m5.objects.SimpleMemory()
else:
mem_ctrl = m5.objects.MemCtrl()
# Hookup the controller to the interface and add to the
list
- mem_ctrl.dram = dram_intf
+ if opt_mem_type != "SimpleMemory":
+ mem_ctrl.dram = dram_intf
+
mem_ctrls.append(mem_ctrl)
elif opt_nvm_type and (not opt_mem_type or range_iter % 2 ==
0):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34595
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v20.1.0.0
Gerrit-Change-Id: I6d60649215be324bdd2a104b1976752f936c960e
Gerrit-Change-Number: 34595
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Ciro Santilli <[email protected]>
Gerrit-CC: Tiago Mück <[email protected]>
Gerrit-CC: Wendy Elsasser <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
