[gem5-dev] Change in gem5/gem5[develop]: arch: Use getTlb in BaseMMU to reduce boilerplate

[Giacomo Travaglini (Gerrit) via gem5-dev]

Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/35735 )

Change subject: arch: Use getTlb in BaseMMU to reduce boilerplate
......................................................................
arch: Use getTlb in BaseMMU to reduce boilerplate

Change-Id: I22dcdf0769e854c252788d415d46da113cb8c60a
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35735
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/generic/mmu.hh
1 file changed, 13 insertions(+), 16 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/generic/mmu.hh b/src/arch/generic/mmu.hh
index 8f7ea88..9765273 100644
--- a/src/arch/generic/mmu.hh
+++ b/src/arch/generic/mmu.hh
@@ -51,6 +51,15 @@
       : SimObject(p), dtb(p.dtb), itb(p.itb)
     {}

+    BaseTLB*
+    getTlb(BaseTLB::Mode mode) const
+    {
+        if (mode == BaseTLB::Execute)
+            return itb;
+        else
+            return dtb;
+    }
+
   public:
     void
     flushAll()
@@ -70,40 +79,28 @@
     translateAtomic(const RequestPtr &req, ThreadContext *tc,
                     BaseTLB::Mode mode)
     {
-        if (mode == BaseTLB::Execute)
-            return itb->translateAtomic(req, tc, mode);
-        else
-            return dtb->translateAtomic(req, tc, mode);
+        return getTlb(mode)->translateAtomic(req, tc, mode);
     }

     void
     translateTiming(const RequestPtr &req, ThreadContext *tc,
                     BaseTLB::Translation *translation, BaseTLB::Mode mode)
     {
-        if (mode == BaseTLB::Execute)
-            return itb->translateTiming(req, tc, translation, mode);
-        else
-            return dtb->translateTiming(req, tc, translation, mode);
+        return getTlb(mode)->translateTiming(req, tc, translation, mode);
     }

     Fault
     translateFunctional(const RequestPtr &req, ThreadContext *tc,
                         BaseTLB::Mode mode)
     {
-        if (mode == BaseTLB::Execute)
-            return itb->translateFunctional(req, tc, mode);
-        else
-            return dtb->translateFunctional(req, tc, mode);
+        return getTlb(mode)->translateFunctional(req, tc, mode);
     }

     Fault
     finalizePhysical(const RequestPtr &req, ThreadContext *tc,
                      BaseTLB::Mode mode) const
     {
-        if (mode == BaseTLB::Execute)
-            return itb->finalizePhysical(req, tc, mode);
-        else
-            return dtb->finalizePhysical(req, tc, mode);
+        return getTlb(mode)->finalizePhysical(req, tc, mode);
     }

     void takeOverFrom(BaseMMU *old_mmu);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/35735
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I22dcdf0769e854c252788d415d46da113cb8c60a
Gerrit-Change-Number: 35735
Gerrit-PatchSet: 7
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s