Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/36817 )
Change subject: dev: Delete the unused DLAB member in the 8250 UART.
......................................................................
dev: Delete the unused DLAB member in the 8250 UART.
This value is never actually used. The value is computed from the LCR
each time it's needed instead.
Change-Id: I6dc5580eb03174f32b8a381cd2974f742b8eb472
---
M src/dev/serial/uart8250.cc
M src/dev/serial/uart8250.hh
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/dev/serial/uart8250.cc b/src/dev/serial/uart8250.cc
index 10dc08e..9f93024 100644
--- a/src/dev/serial/uart8250.cc
+++ b/src/dev/serial/uart8250.cc
@@ -84,7 +84,7 @@
Uart8250::Uart8250(const Params &p)
- : Uart(p, 8), IER(0), DLAB(0), LCR(0), MCR(0), lastTxInt(0),
+ : Uart(p, 8), IER(0), LCR(0), MCR(0), lastTxInt(0),
txIntrEvent([this]{ processIntrEvent(TX_INT); }, "TX"),
rxIntrEvent([this]{ processIntrEvent(RX_INT); }, "RX")
{
@@ -285,7 +285,6 @@
{
SERIALIZE_SCALAR(status);
SERIALIZE_SCALAR(IER);
- SERIALIZE_SCALAR(DLAB);
SERIALIZE_SCALAR(LCR);
SERIALIZE_SCALAR(MCR);
Tick rxintrwhen;
@@ -307,7 +306,6 @@
{
UNSERIALIZE_SCALAR(status);
UNSERIALIZE_SCALAR(IER);
- UNSERIALIZE_SCALAR(DLAB);
UNSERIALIZE_SCALAR(LCR);
UNSERIALIZE_SCALAR(MCR);
Tick rxintrwhen;
diff --git a/src/dev/serial/uart8250.hh b/src/dev/serial/uart8250.hh
index 3209416..b18079d 100644
--- a/src/dev/serial/uart8250.hh
+++ b/src/dev/serial/uart8250.hh
@@ -68,7 +68,7 @@
class Uart8250 : public Uart
{
protected:
- uint8_t IER, DLAB, LCR, MCR;
+ uint8_t IER, LCR, MCR;
Tick lastTxInt;
void processIntrEvent(int intrBit);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/36817
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6dc5580eb03174f32b8a381cd2974f742b8eb472
Gerrit-Change-Number: 36817
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
