Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/35244 )
Change subject: arch-arm: TlbEntry flush to be considered as functional
lookup
......................................................................
arch-arm: TlbEntry flush to be considered as functional lookup
Otherwise we are unnecessarily shifting the TLB entry to the
MRU position before invalidating it
Change-Id: I43ee04cd5267829ab7357f4fe1ff745023adc598
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/35244
Reviewed-by: Nikos Nikoleris <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/tlb.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/tlb.cc b/src/arch/arm/tlb.cc
index bad16d8..04b5cd4 100644
--- a/src/arch/arm/tlb.cc
+++ b/src/arch/arm/tlb.cc
@@ -446,7 +446,7 @@
bool hyp = target_el == EL2;
- te = lookup(mva, asn, vmid, hyp, secure_lookup, false, ignore_asn,
+ te = lookup(mva, asn, vmid, hyp, secure_lookup, true, ignore_asn,
target_el, in_host);
while (te != NULL) {
if (secure_lookup == !te->nstid) {
@@ -454,7 +454,7 @@
te->valid = false;
stats.flushedEntries++;
}
- te = lookup(mva, asn, vmid, hyp, secure_lookup, false, ignore_asn,
+ te = lookup(mva, asn, vmid, hyp, secure_lookup, true, ignore_asn,
target_el, in_host);
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/35244
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I43ee04cd5267829ab7357f4fe1ff745023adc598
Gerrit-Change-Number: 35244
Gerrit-PatchSet: 10
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s