Attention is currently required from: Bobby R. Bruce, Giacomo Travaglini,
Gabe Black.
Hello kokoro, Bobby R. Bruce, Giacomo Travaglini, Gabe Black,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/37119
to review the following change.
Change subject: Revert "arch-x86, cpu-kvm: add x86 kvm test to long
regression"
......................................................................
Revert "arch-x86, cpu-kvm: add x86 kvm test to long regression"
This reverts commit 04b87cc29ae5195e0c2fcc1ad895b350de4aa066.
Reason for revert: should not have pushed, missed comments.
Change-Id: I91e32a0a4fbe1ea0c1e0b4aae88ffa1667bdec26
---
M tests/gem5/x86-boot-tests/test_linux_boot.py
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/tests/gem5/x86-boot-tests/test_linux_boot.py
b/tests/gem5/x86-boot-tests/test_linux_boot.py
index 94b6e7e..d73f3a1 100644
--- a/tests/gem5/x86-boot-tests/test_linux_boot.py
+++ b/tests/gem5/x86-boot-tests/test_linux_boot.py
@@ -25,9 +25,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import os
-import subprocess
from testlib import *
-import platform
if config.bin_path:
@@ -45,10 +43,8 @@
image = DownloadedProgram(image_url, base_path, image_name, True)
kernel = DownloadedProgram(kernel_url, base_path, kernel_name)
-def support_kvm():
- return os.access("/dev/kvm", os.R_OK | os.W_OK)
-def test_boot(cpu_type, num_cpus, boot_type, host):
+def test_boot(cpu_type, num_cpus, boot_type):
gem5_verify_config(
name = 'test-ubuntu_boot-' + cpu_type + '_cpu-' + num_cpus
+ '_cpus-'
+ boot_type + '_boot',
@@ -63,19 +59,14 @@
'--boot-type', boot_type,
],
valid_isas = ('X86',),
- valid_hosts = host,
+ valid_hosts = constants.supported_hosts,
length = constants.long_tag,
)
# Test every CPU type
cpu_types = ('atomic', 'simple',)
for cpu_type in cpu_types:
- test_boot(cpu_type, '1', 'init', constants.supported_hosts)
+ test_boot(cpu_type, '1', 'init')
# Test a multicore system
-test_boot('atomic', '4', 'systemd', constants.supported_hosts)
-
-#KVM
-if(support_kvm() and (platform.machine() == constants.host_x86_64_tag)):
- test_boot('kvm', '1', 'init', (constants.host_x86_64_tag,))
- test_boot('kvm', '4', 'systemd', (constants.host_x86_64_tag,))
+test_boot('atomic', '4', 'systemd')
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/37119
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I91e32a0a4fbe1ea0c1e0b4aae88ffa1667bdec26
Gerrit-Change-Number: 37119
Gerrit-PatchSet: 1
Gerrit-Owner: mike upton <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-Attention: Bobby R. Bruce <[email protected]>
Gerrit-Attention: Giacomo Travaglini <[email protected]>
Gerrit-Attention: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
