Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/36880 )
Change subject: mips: Convert MIPS to use local register index storage.
......................................................................
mips: Convert MIPS to use local register index storage.
Change-Id: Ib691f3dd666c0877fc53b2f50dbaaf7bb4a6905b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/36880
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/mips/isa/formats/basic.isa
M src/arch/mips/isa/formats/mem.isa
2 files changed, 14 insertions(+), 7 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/mips/isa/formats/basic.isa
b/src/arch/mips/isa/formats/basic.isa
index 17d08ef..765dae2 100644
--- a/src/arch/mips/isa/formats/basic.isa
+++ b/src/arch/mips/isa/formats/basic.isa
@@ -35,19 +35,23 @@
*/
class %(class_name)s : public %(base_class)s
{
+ private:
+ %(reg_idx_arr_decl)s;
public:
- /// Constructor.
- %(class_name)s(MachInst machInst);
- Fault execute(ExecContext *,
- Trace::InstRecord *) const override;
+ /// Constructor.
+ %(class_name)s(MachInst machInst);
+ Fault execute(ExecContext *,
+ Trace::InstRecord *) const override;
};
}};
// Basic instruction class constructor template.
def template BasicConstructor {{
- %(class_name)s::%(class_name)s(MachInst
machInst) : %(base_class)s("%(mnemonic)s", machInst, %(op_class)s)
+ %(class_name)s::%(class_name)s(MachInst machInst) :
+ %(base_class)s("%(mnemonic)s", machInst, %(op_class)s)
{
- %(constructor)s;
+ %(set_reg_idx_arr)s;
+ %(constructor)s;
}
}};
diff --git a/src/arch/mips/isa/formats/mem.isa
b/src/arch/mips/isa/formats/mem.isa
index a31485d..ac56803 100644
--- a/src/arch/mips/isa/formats/mem.isa
+++ b/src/arch/mips/isa/formats/mem.isa
@@ -129,8 +129,10 @@
*/
class %(class_name)s : public %(base_class)s
{
- public:
+ private:
+ %(reg_idx_arr_decl)s;
+ public:
/// Constructor.
%(class_name)s(ExtMachInst machInst);
@@ -146,6 +148,7 @@
%(class_name)s::%(class_name)s(ExtMachInst machInst)
: %(base_class)s("%(mnemonic)s", machInst, %(op_class)s)
{
+ %(set_reg_idx_arr)s;
%(constructor)s;
}
}};
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/36880
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib691f3dd666c0877fc53b2f50dbaaf7bb4a6905b
Gerrit-Change-Number: 36880
Gerrit-PatchSet: 9
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Boris Shingarov <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
