Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/38177 )
Change subject: mem-cache: Fix update of useful prefetches
......................................................................
mem-cache: Fix update of useful prefetches
The probe notification must be parsed on every hit, even if
the prefetcher is set not to generate prefetches on accesses.
This fixes the calculation of useful prefetches.
Change-Id: Iff298f7bea11013f411f4ba39dba705fd81a0cd4
Signed-off-by: Daniel R. Carvalho <oda...@yahoo.com.br>
---
M src/mem/cache/prefetch/base.cc
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/mem/cache/prefetch/base.cc b/src/mem/cache/prefetch/base.cc
index 28aaa62..5a34ac6 100644
--- a/src/mem/cache/prefetch/base.cc
+++ b/src/mem/cache/prefetch/base.cc
@@ -125,6 +125,7 @@
bool read = pkt->isRead();
bool inv = pkt->isInvalidate();
+ if (!miss && prefetchOnAccess) return false;
if (pkt->req->isUncacheable()) return false;
if (fetch && !onInst) return false;
if (!fetch && !onData) return false;
@@ -236,10 +237,8 @@
true));
listeners.push_back(new PrefetchListener(*this, pm, "Fill", true,
false));
- if (prefetchOnAccess) {
- listeners.push_back(new PrefetchListener(*this, pm, "Hit",
false,
- false));
- }
+ listeners.push_back(new PrefetchListener(*this, pm, "Hit", false,
+ false));
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38177
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iff298f7bea11013f411f4ba39dba705fd81a0cd4
Gerrit-Change-Number: 38177
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
