Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/38383 )
Change subject: arch: Fix the code that computes MaxMiscDestReg.
......................................................................
arch: Fix the code that computes MaxMiscDestReg.
This code was simplified a little while ago, and the wrong variable name
was used in that computation accidentally. Fortunately the "wrong" value
would be too large, and so nothing bad would happen except a pair of
arrays would be overly large in the O3 instruction class.
Change-Id: I9694f1a8c79a62a172ef63bdd2f98fa0ace06acd
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38383
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/isa_parser/operand_list.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/isa_parser/operand_list.py
b/src/arch/isa_parser/operand_list.py
index 12a23d9..cea3ae4 100755
--- a/src/arch/isa_parser/operand_list.py
+++ b/src/arch/isa_parser/operand_list.py
@@ -135,7 +135,7 @@
parser.maxInstSrcRegs = max(parser.maxInstSrcRegs, self.numSrcRegs)
parser.maxInstDestRegs = max(parser.maxInstDestRegs,
self.numDestRegs)
- parser.maxMiscDestRegs = max(parser.maxInstDestRegs,
+ parser.maxMiscDestRegs = max(parser.maxMiscDestRegs,
self.numMiscDestRegs)
# now make a final pass to finalize op_desc fields that may depend
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38383
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9694f1a8c79a62a172ef63bdd2f98fa0ace06acd
Gerrit-Change-Number: 38383
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
