Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39563 )
Change subject: misc: Stop "using namespace std" in protoio.cc.
......................................................................
misc: Stop "using namespace std" in protoio.cc.
Change-Id: I4f27979910230860c631b63bb500f87b45c24e33
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39563
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/proto/protoio.cc
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/proto/protoio.cc b/src/proto/protoio.cc
index 691d4ee..72e463b 100644
--- a/src/proto/protoio.cc
+++ b/src/proto/protoio.cc
@@ -39,11 +39,11 @@
#include "base/logging.hh"
-using namespace std;
using namespace google::protobuf;
-ProtoOutputStream::ProtoOutputStream(const string& filename) :
- fileStream(filename.c_str(), ios::out | ios::binary | ios::trunc),
+ProtoOutputStream::ProtoOutputStream(const std::string& filename) :
+ fileStream(filename.c_str(),
+ std::ios::out | std::ios::binary | std::ios::trunc),
wrappedFileStream(NULL), gzipStream(NULL), zeroCopyStream(NULL)
{
if (!fileStream.good())
@@ -98,9 +98,9 @@
msg.SerializeWithCachedSizes(&codedStream);
}
-ProtoInputStream::ProtoInputStream(const string& filename) :
- fileStream(filename.c_str(), ios::in | ios::binary),
fileName(filename),
- useGzip(false),
+ProtoInputStream::ProtoInputStream(const std::string& filename) :
+ fileStream(filename.c_str(), std::ios::in | std::ios::binary),
+ fileName(filename), useGzip(false),
wrappedFileStream(NULL), gzipStream(NULL), zeroCopyStream(NULL)
{
if (!fileStream.good())
@@ -113,7 +113,7 @@
// seek to the start of the input file and clear any flags
fileStream.clear();
- fileStream.seekg(0, ifstream::beg);
+ fileStream.seekg(0, std::ifstream::beg);
createStreams();
}
@@ -172,7 +172,7 @@
destroyStreams();
// seek to the start of the input file and clear any flags
fileStream.clear();
- fileStream.seekg(0, ifstream::beg);
+ fileStream.seekg(0, std::ifstream::beg);
createStreams();
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39563
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4f27979910230860c631b63bb500f87b45c24e33
Gerrit-Change-Number: 39563
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s