Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/39661 )
Change subject: base: Make the default checkBpLen method return true.
......................................................................
base: Make the default checkBpLen method return true.
This was checking that the breakpoint length was equal to the length of
the ISA specific MachInst type. Instead, force the ISA specific remote
GDB subclass to implement a check if it wants to, specific to its needs.
The base implementation will just approve of any length, which should be
fine with a well behaved GDB client.
Change-Id: Id7325b788f8445049855f8104082b8e4da1fe300
---
M src/base/remote_gdb.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc
index 02cb11a..8cb1bfe 100644
--- a/src/base/remote_gdb.cc
+++ b/src/base/remote_gdb.cc
@@ -786,7 +786,7 @@
bool
BaseRemoteGDB::checkBpLen(size_t len)
{
- return len == sizeof(TheISA::MachInst);
+ return true;
}
bool
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39661
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id7325b788f8445049855f8104082b8e4da1fe300
Gerrit-Change-Number: 39661
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
