Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/38797 )
Change subject: system-arm: Enabled HDLcd by default in DTS
......................................................................
system-arm: Enabled HDLcd by default in DTS
This is fine as people using *_hdlcd.dtsi are willing to simulate
an HDLcd
JIRA: https://gem5.atlassian.net/browse/GEM5-866
Change-Id: Ifd5d6ecc81de920dbc29a05b07f30c13dcee3aa4
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38797
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M system/arm/dt/platforms/display.dtsi
M system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
M system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
3 files changed, 4 insertions(+), 15 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/system/arm/dt/platforms/display.dtsi
b/system/arm/dt/platforms/display.dtsi
index 16a029a..64c41e6 100644
--- a/system/arm/dt/platforms/display.dtsi
+++ b/system/arm/dt/platforms/display.dtsi
@@ -55,8 +55,6 @@
};
&dp0 {
- status = "ok";
-
port {
dp0_output: endpoint@0 {
remote-endpoint = <&dp0_virt_input>;
diff --git a/system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
b/system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
index efca66d..a11dcb6 100644
--- a/system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
+++ b/system/arm/dt/platforms/vexpress_gem5_v1_hdlcd.dtsi
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2015-2019 ARM Limited
+ * Copyright (c) 2015-2019, 2021 ARM Limited
* All rights reserved
*
* Redistribution and use in source and binary forms, with or without
@@ -29,18 +29,13 @@
/include/ "vexpress_gem5_v1_base.dtsi"
/ {
- /* The display processor needs custom configuration to setup its
- * output ports. Disable it by default in the platform until the
- * DT bindings have stabilize.
- */
dp0: hdlcd@2b000000 {
compatible = "arm,hdlcd";
reg = <0x0 0x2b000000 0x0 0x1000>;
interrupts = <0 63 4>;
clocks = <&osc_pxl>;
clock-names = "pxlclk";
-
- status = "disabled";
+ status = "ok";
};
};
diff --git a/system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
b/system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
index 6775727..3e8003a 100644
--- a/system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
+++ b/system/arm/dt/platforms/vexpress_gem5_v2_hdlcd.dtsi
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2015-2019 ARM Limited
+ * Copyright (c) 2015-2019, 2021 ARM Limited
* All rights reserved
*
* Redistribution and use in source and binary forms, with or without
@@ -29,17 +29,13 @@
/include/ "vexpress_gem5_v2_base.dtsi"
/ {
- /* The display processor needs custom configuration to setup its
- * output ports. Disable it by default in the platform until the
- * DT bindings have stabilize.
- */
dp0: hdlcd@2b000000 {
compatible = "arm,hdlcd";
reg = <0x0 0x2b000000 0x0 0x1000>;
interrupts = <0 63 4>;
clocks = <&osc_pxl>;
clock-names = "pxlclk";
- status = "disabled";
+ status = "ok";
};
};
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/38797
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifd5d6ecc81de920dbc29a05b07f30c13dcee3aa4
Gerrit-Change-Number: 38797
Gerrit-PatchSet: 5
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
