Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39698 )
Change subject: dev-arm: A SystemCounterListener doesn't have to be
Serializable
......................................................................
dev-arm: A SystemCounterListener doesn't have to be Serializable
The class is not making use of any Serializable utility.
By removing this dependency we can extend it more easilly
Change-Id: Ia321b8f0deeb92adde008551eb921dcfd365e675
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39698
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/dev/arm/generic_timer.hh
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/arm/generic_timer.hh b/src/dev/arm/generic_timer.hh
index 16d2ce3..9a6663c 100644
--- a/src/dev/arm/generic_timer.hh
+++ b/src/dev/arm/generic_timer.hh
@@ -71,7 +71,7 @@
/// Abstract class for elements whose events depend on the counting speed
/// of the System Counter
-class SystemCounterListener : public Serializable
+class SystemCounterListener
{
public:
/// Called from the SystemCounter when a change in counting speed
occurred
@@ -174,7 +174,8 @@
};
/// Per-CPU architected timer.
-class ArchTimer : public SystemCounterListener, public Drainable
+class ArchTimer : public SystemCounterListener, public Drainable,
+ public Serializable
{
protected:
/// Control register.
@@ -297,7 +298,7 @@
RegVal readMiscReg(int misc_reg, unsigned cpu);
protected:
- class CoreTimers : public SystemCounterListener
+ class CoreTimers : public SystemCounterListener, public Serializable
{
public:
CoreTimers(GenericTimer &_parent, ArmSystem &system, unsigned cpu,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39698
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia321b8f0deeb92adde008551eb921dcfd365e675
Gerrit-Change-Number: 39698
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
