Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40375 )
Change subject: arch-arm: Add destRegIdxArr arrays to TME instructions
......................................................................
arch-arm: Add destRegIdxArr arrays to TME instructions
This is needed as the base StaticInst class is no longer holding the
index array and it is up to the derived class to allocate the
storage depending on the number of registers used
Change-Id: I389e39a7e09d31f370d63a6e61fe6ee3faaac7db
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40375
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/arm/insts/tme64.cc
M src/arch/arm/insts/tme64.hh
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, but someone else must approve
kokoro: Regressions pass
diff --git a/src/arch/arm/insts/tme64.cc b/src/arch/arm/insts/tme64.cc
index d32e8c9..85ffd6d 100644
--- a/src/arch/arm/insts/tme64.cc
+++ b/src/arch/arm/insts/tme64.cc
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2020 ARM Limited
+ * Copyright (c) 2020-2021 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -116,6 +116,12 @@
Tstart64::Tstart64(ExtMachInst machInst, IntRegIndex _dest)
: TmeRegNone64("tstart", machInst, MemReadOp, _dest)
{
+ setRegIdxArrays(
+ nullptr,
+ reinterpret_cast<RegIdArrayPtr>(
+ &std::remove_pointer_t<decltype(this)>::destRegIdxArr));
+ ;
+
_numSrcRegs = 0;
_numDestRegs = 0;
_numFPDestRegs = 0;
@@ -144,6 +150,12 @@
Ttest64::Ttest64(ExtMachInst machInst, IntRegIndex _dest)
: TmeRegNone64("ttest", machInst, MemReadOp, _dest)
{
+ setRegIdxArrays(
+ nullptr,
+ reinterpret_cast<RegIdArrayPtr>(
+ &std::remove_pointer_t<decltype(this)>::destRegIdxArr));
+ ;
+
_numSrcRegs = 0;
_numDestRegs = 0;
_numFPDestRegs = 0;
diff --git a/src/arch/arm/insts/tme64.hh b/src/arch/arm/insts/tme64.hh
index b75adc1..0a1e02c 100644
--- a/src/arch/arm/insts/tme64.hh
+++ b/src/arch/arm/insts/tme64.hh
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2020 ARM Limited
+ * Copyright (c) 2020-2021 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -97,6 +97,9 @@
class Tstart64 : public TmeRegNone64
{
+ private:
+ RegId destRegIdxArr[1];
+
public:
Tstart64(ArmISA::ExtMachInst, ArmISA::IntRegIndex);
@@ -107,6 +110,9 @@
class Ttest64 : public TmeRegNone64
{
+ private:
+ RegId destRegIdxArr[1];
+
public:
Ttest64(ArmISA::ExtMachInst, ArmISA::IntRegIndex);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40375
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I389e39a7e09d31f370d63a6e61fe6ee3faaac7db
Gerrit-Change-Number: 40375
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
