[gem5-dev] Change in gem5/gem5[develop]: base: Fix storage params safe_cast

[Daniel Carvalho (Gerrit) via gem5-dev]

Daniel Carvalho has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/40555 )

Change subject: base: Fix storage params safe_cast
......................................................................

base: Fix storage params safe_cast

Although they provide the exact same behavior, the params
created in the tests did not have the type expected by the
internal safe cast.

The following error was triggered:

storage.test.debug: build/NULL/base/cast.hh:47: T safe_cast(U)
 [with T = const Stats::SampleStor::Params*;
  U = const Stats::StorageParams*]:
 Assertion `ret' failed.

Change-Id: I4f2ba51f3ccdb44589e61f235997245e7d9bf3c9
Signed-off-by: Daniel R. Carvalho <oda...@yahoo.com.br>
---
M src/base/stats/storage.test.cc
1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/src/base/stats/storage.test.cc b/src/base/stats/storage.test.cc
index 717c881..8a4f6ed 100644
--- a/src/base/stats/storage.test.cc
+++ b/src/base/stats/storage.test.cc
@@ -1083,7 +1083,7 @@
     Stats::Counter val;
     Stats::DistData data;
     Stats::DistData expected_data;
-    Stats::DistParams params(Stats::Deviation);
+    Stats::SampleStor::Params params;
     MockInfo info(&params);

     // Simple test with one value being sampled
@@ -1133,7 +1133,7 @@
     Stats::Counter val = 10;
     Stats::Counter num_samples = 5;
     Stats::DistData data;
-    Stats::DistParams params(Stats::Deviation);
+    Stats::SampleStor::Params params;
     MockInfo info(&params);

     ASSERT_EQ(stor.size(), 1);
@@ -1177,7 +1177,7 @@
     Stats::Counter val;
     Stats::DistData data;
     Stats::DistData expected_data;
-    Stats::DistParams params(Stats::Deviation);
+    Stats::AvgSampleStor::Params params;
     MockInfo info(&params);

     // Simple test with one value being sampled
@@ -1228,7 +1228,7 @@
     Stats::Counter val = 10;
     Stats::Counter num_samples = 5;
     Stats::DistData data;
-    Stats::DistParams params(Stats::Deviation);
+    Stats::AvgSampleStor::Params params;
     MockInfo info(&params);

     ASSERT_EQ(stor.size(), 1);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40555
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4f2ba51f3ccdb44589e61f235997245e7d9bf3c9
Gerrit-Change-Number: 40555
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s