Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40619 )
Change subject: base: Remove unnecessary includes from
base/loader/symtab.[cc|hh].
......................................................................
base: Remove unnecessary includes from base/loader/symtab.[cc|hh].
These were either completely unnecessary, or headers in the .cc which
had already been included in the .hh and were not needed beyond their
use in the .hh.
Change-Id: Ic95e29f3fdd8cab00ab93d254d2e1c25aacf4632
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40619
Reviewed-by: Daniel Carvalho <oda...@yahoo.com.br>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/loader/symtab.cc
M src/base/loader/symtab.hh
2 files changed, 3 insertions(+), 9 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/loader/symtab.cc b/src/base/loader/symtab.cc
index 2a23661..c2c53cc 100644
--- a/src/base/loader/symtab.cc
+++ b/src/base/loader/symtab.cc
@@ -30,14 +30,9 @@
#include <fstream>
#include <iostream>
-#include <string>
-#include <vector>
#include "base/logging.hh"
#include "base/str.hh"
-#include "base/trace.hh"
-#include "base/types.hh"
-#include "sim/serialize.hh"
namespace Loader
{
diff --git a/src/base/loader/symtab.hh b/src/base/loader/symtab.hh
index 1e99fec..a0203a6 100644
--- a/src/base/loader/symtab.hh
+++ b/src/base/loader/symtab.hh
@@ -26,8 +26,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef __SYMTAB_HH__
-#define __SYMTAB_HH__
+#ifndef __BASE_LOADER_SYMTAB_HH__
+#define __BASE_LOADER_SYMTAB_HH__
#include <functional>
#include <iosfwd>
@@ -36,7 +36,6 @@
#include <string>
#include <vector>
-#include "base/trace.hh"
#include "base/types.hh"
#include "sim/serialize.hh"
@@ -239,4 +238,4 @@
} // namespace Loader
-#endif // __SYMTAB_HH__
+#endif // __BASE_LOADER_SYMTAB_HH__
The change was submitted with unreviewed changes in the following files:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40619
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic95e29f3fdd8cab00ab93d254d2e1c25aacf4632
Gerrit-Change-Number: 40619
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
