Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/40875 )
Change subject: scons: Eliminate the redundant "--colors" scons command
line option.
......................................................................
scons: Eliminate the redundant "--colors" scons command line option.
The default behavior already is to add color to the output. The option
had an action of 'store_true' which would normally set the default value
to False, but the --no-colors option immediately after it had the action
'store_false' which apparently set the common dest 'use_colors' to True
by default. The net effect was that the --colors option did nothing.
Change-Id: I6d6473f85921f90bb629ecb32a0f0f81c02d7914
---
M SConstruct
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/SConstruct b/SConstruct
index 7444f83..1b76fe5 100755
--- a/SConstruct
+++ b/SConstruct
@@ -94,8 +94,6 @@
from m5.util import compareVersions, readCommand, readCommandWithReturn
-AddOption('--colors', dest='use_colors', action='store_true',
- help="Add color to abbreviated scons output")
AddOption('--no-colors', dest='use_colors', action='store_false',
help="Don't add color to abbreviated scons output")
AddOption('--with-cxx-config', action='store_true',
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40875
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I6d6473f85921f90bb629ecb32a0f0f81c02d7914
Gerrit-Change-Number: 40875
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
