Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40655 )
Change subject: mem: Remove units from stats description
......................................................................
mem: Remove units from stats description
The change https://gem5-review.googlesource.com/c/public/gem5/+/40622
allows units to be shown in stats dump, the units in stats
descriptions are nolonger necessary. This change removes units
from stats descriptions. However, for units that are multiples
of a supported unit (e.g. MegaBytes), the units in the descriptions
are kept until unit prefixes are supported.
Change-Id: I4d87139290a8458e87da776e4328edbd6c224546
Signed-off-by: Hoa Nguyen <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40655
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/mem/abstract_mem.cc
M src/mem/cache/compressors/base.cc
M src/mem/comm_monitor.cc
M src/mem/mem_ctrl.cc
M src/mem/qos/mem_ctrl.cc
M src/mem/xbar.cc
6 files changed, 15 insertions(+), 17 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/abstract_mem.cc b/src/mem/abstract_mem.cc
index 33379af..a3e4db8 100644
--- a/src/mem/abstract_mem.cc
+++ b/src/mem/abstract_mem.cc
@@ -123,13 +123,13 @@
ADD_STAT(numOther, UNIT_COUNT,
"Number of other requests responded to by this memory"),
ADD_STAT(bwRead, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total read bandwidth from this memory (bytes/s)"),
+ "Total read bandwidth from this memory"),
ADD_STAT(bwInstRead, UNIT_RATE(Stats::Units::Byte,
Stats::Units::Second),
- "Instruction read bandwidth from this memory (bytes/s)"),
+ "Instruction read bandwidth from this memory"),
ADD_STAT(bwWrite, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Write bandwidth from this memory (bytes/s)"),
+ "Write bandwidth from this memory"),
ADD_STAT(bwTotal, UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Total bandwidth to/from this memory (bytes/s)")
+ "Total bandwidth to/from this memory")
{
}
diff --git a/src/mem/cache/compressors/base.cc
b/src/mem/cache/compressors/base.cc
index e83cb6b..87f41a4 100644
--- a/src/mem/cache/compressors/base.cc
+++ b/src/mem/cache/compressors/base.cc
@@ -233,11 +233,10 @@
ADD_STAT(compressionSize, UNIT_COUNT,
"Number of blocks that were compressed to this power of two "
"size"),
- ADD_STAT(compressionSizeBits, UNIT_BIT,
- "Total compressed data size, in bits"),
+ ADD_STAT(compressionSizeBits, UNIT_BIT, "Total compressed data size"),
ADD_STAT(avgCompressionSizeBits,
UNIT_RATE(Stats::Units::Bit, Stats::Units::Count),
- "Average compression size, in bits"),
+ "Average compression size"),
ADD_STAT(decompressions, UNIT_COUNT, "Total number of decompressions")
{
}
diff --git a/src/mem/comm_monitor.cc b/src/mem/comm_monitor.cc
index dffc8d1..8807a73 100644
--- a/src/mem/comm_monitor.cc
+++ b/src/mem/comm_monitor.cc
@@ -110,23 +110,23 @@
readBytes(0),
ADD_STAT(readBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of read bandwidth per sample period (bytes/s)"),
+ "Histogram of read bandwidth per sample period"),
ADD_STAT(totalReadBytes, UNIT_BYTE, "Number of bytes read"),
ADD_STAT(averageReadBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average read bandwidth (bytes/s)",
+ "Average read bandwidth",
totalReadBytes / simSeconds),
writtenBytes(0),
ADD_STAT(writeBandwidthHist,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Histogram of write bandwidth (bytes/s)"),
+ "Histogram of write bandwidth"),
ADD_STAT(totalWrittenBytes,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
"Number of bytes written"),
ADD_STAT(averageWriteBandwidth,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Average write bandwidth (bytes/s)",
+ "Average write bandwidth",
totalWrittenBytes / simSeconds),
disableLatencyHists(params.disable_latency_hists),
diff --git a/src/mem/mem_ctrl.cc b/src/mem/mem_ctrl.cc
index 63c62ae..607d994 100644
--- a/src/mem/mem_ctrl.cc
+++ b/src/mem/mem_ctrl.cc
@@ -1249,10 +1249,10 @@
"Per-requestor bytes write to memory"),
ADD_STAT(requestorReadRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Per-requestor bytes read from memory rate (Bytes/sec)"),
+ "Per-requestor bytes read from memory rate"),
ADD_STAT(requestorWriteRate,
UNIT_RATE(Stats::Units::Byte, Stats::Units::Second),
- "Per-requestor bytes write to memory rate (Bytes/sec)"),
+ "Per-requestor bytes write to memory rate"),
ADD_STAT(requestorReadAccesses, UNIT_COUNT,
"Per-requestor read serviced memory accesses"),
ADD_STAT(requestorWriteAccesses, UNIT_COUNT,
diff --git a/src/mem/qos/mem_ctrl.cc b/src/mem/qos/mem_ctrl.cc
index 82be0f4..ca72a7c 100644
--- a/src/mem/qos/mem_ctrl.cc
+++ b/src/mem/qos/mem_ctrl.cc
@@ -285,9 +285,9 @@
"values"),
ADD_STAT(priorityMinLatency, UNIT_SECOND,
- "per QoS priority minimum request to response latency (s)"),
+ "per QoS priority minimum request to response latency"),
ADD_STAT(priorityMaxLatency, UNIT_SECOND,
- "per QoS priority maximum request to response latency (s)"),
+ "per QoS priority maximum request to response latency"),
ADD_STAT(numReadWriteTurnArounds, UNIT_COUNT,
"Number of turnarounds from READ to WRITE"),
ADD_STAT(numWriteReadTurnArounds, UNIT_COUNT,
diff --git a/src/mem/xbar.cc b/src/mem/xbar.cc
index 94829a7..41ad585 100644
--- a/src/mem/xbar.cc
+++ b/src/mem/xbar.cc
@@ -67,8 +67,7 @@
ADD_STAT(pktCount, UNIT_COUNT,
"Packet count per connected requestor and responder"),
ADD_STAT(pktSize, UNIT_BYTE,
- "Cumulative packet size per connected requestor and
responder "
- "(bytes)")
+ "Cumulative packet size per connected requestor and
responder")
{
}
The change was submitted with unreviewed changes in the following files:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40655
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4d87139290a8458e87da776e4328edbd6c224546
Gerrit-Change-Number: 40655
Gerrit-PatchSet: 13
Gerrit-Owner: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
