Tiago Mück has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/41114 )
Change subject: mem-ruby: fix Sequencer latency reporting
......................................................................
mem-ruby: fix Sequencer latency reporting
Most protocols won't set initialRequestTime, forwardRequestTime, and
firstResponseTime, thus leading to calculated latency being always 0.
Change-Id: Id2c73314a964bf6efb262d40b3df515373023b84
Signed-off-by: Tiago Mück <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/41114
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/system/Sequencer.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/system/Sequencer.cc
b/src/mem/ruby/system/Sequencer.cc
index ab83677..49c0351 100644
--- a/src/mem/ruby/system/Sequencer.cc
+++ b/src/mem/ruby/system/Sequencer.cc
@@ -334,7 +334,7 @@
assert(curCycle() >= issued_time);
Cycles total_lat = completion_time - issued_time;
- if (initialRequestTime < issued_time) {
+ if ((initialRequestTime != 0) && (initialRequestTime < issued_time)) {
// if the request was combined in the protocol with an earlier
request
// for the same address, it is possible that it will return an
// initialRequestTime corresponding the earlier request. Since
Cycles
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41114
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id2c73314a964bf6efb262d40b3df515373023b84
Gerrit-Change-Number: 41114
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Mück <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Tiago Mück <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
