[gem5-dev] Change in gem5/gem5[develop]: misc: Remove unused params() definitions

Giacomo Travaglini (Gerrit) via gem5-dev Thu, 18 Feb 2021 03:38:08 -0800

Giacomo Travaglini has uploaded this change for review. (https://gem5-review.googlesource.com/c/public/gem5/+/41613 )


Change subject: misc: Remove unused params() definitions
......................................................................

misc: Remove unused params() definitions

Lots of times the params() helper has been defined but not used

Change-Id: Id71829aca71341d46964d8f071099342b946b62f
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
---
M src/arch/arm/fastmodel/iris/interrupts.hh
M src/arch/arm/freebsd/se_workload.hh
M src/arch/arm/interrupts.hh
M src/arch/arm/linux/se_workload.hh
M src/arch/arm/nativetrace.hh
M src/arch/arm/se_workload.hh
M src/arch/arm/tlb.hh
M src/arch/generic/interrupts.hh
M src/arch/mips/interrupts.hh
M src/arch/mips/isa.hh
M src/arch/mips/linux/se_workload.hh
M src/arch/mips/se_workload.hh
M src/arch/power/interrupts.hh
M src/arch/power/isa.hh
M src/arch/power/linux/se_workload.hh
M src/arch/power/se_workload.hh
M src/arch/riscv/interrupts.hh
M src/arch/riscv/isa.hh
M src/arch/riscv/linux/se_workload.hh
M src/arch/riscv/pagetable_walker.hh
M src/arch/riscv/se_workload.hh
M src/arch/sparc/interrupts.hh
M src/arch/sparc/isa.hh
M src/arch/sparc/linux/se_workload.hh
M src/arch/x86/fs_workload.hh
M src/arch/x86/interrupts.hh
M src/arch/x86/isa.hh
M src/arch/x86/linux/se_workload.hh
M src/arch/x86/pagetable_walker.hh
M src/dev/arm/gic_v2.hh
M src/dev/arm/pl111.hh
M src/dev/arm/realview.hh
M src/dev/arm/rtc_pl031.hh
M src/dev/arm/timer_a9global.hh
M src/dev/arm/timer_sp804.hh
M src/dev/arm/vgic.hh
M src/dev/baddev.hh
M src/dev/io_device.hh
M src/dev/mips/malta_cchip.hh
M src/dev/net/dist_etherlink.hh
M src/dev/net/etherbus.hh
M src/dev/net/etherdevice.hh
M src/dev/net/etherlink.hh
M src/dev/net/etherswitch.hh
M src/dev/net/ethertap.hh
M src/dev/serial/uart.hh
M src/dev/serial/uart8250.hh
M src/dev/sparc/dtod.hh
M src/dev/sparc/mm_disk.hh
M src/dev/x86/i8042.hh
M src/dev/x86/i82094aa.hh
M src/dev/x86/i8237.hh
M src/dev/x86/i8254.hh
M src/dev/x86/i8259.hh
M src/dev/x86/south_bridge.hh
M src/dev/x86/speaker.hh
M src/gpu-compute/lds_state.hh
M src/mem/comm_monitor.hh
M src/mem/mem_checker_monitor.hh
M src/mem/qos/policy_pf.hh
M src/mem/ruby/network/fault_model/FaultModel.hh
M src/sim/clocked_object.hh
M src/sim/se_workload.hh
63 files changed, 68 insertions(+), 69 deletions(-)

diff --git a/src/arch/arm/fastmodel/iris/interrupts.hhb/src/arch/arm/fastmodel/iris/interrupts.hh

index 344d9c5..c73a628 100644
--- a/src/arch/arm/fastmodel/iris/interrupts.hh
+++ b/src/arch/arm/fastmodel/iris/interrupts.hh
@@ -38,7 +38,7 @@
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(IrisInterrupts);
+    using Params = IrisInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p) {}

diff --git a/src/arch/arm/freebsd/se_workload.hhb/src/arch/arm/freebsd/se_workload.hh

index 82d3659..a228ee0 100644
--- a/src/arch/arm/freebsd/se_workload.hh
+++ b/src/arch/arm/freebsd/se_workload.hh
@@ -46,7 +46,7 @@
 class EmuFreebsd : public SEWorkload
 {
   public:
-    PARAMS(ArmEmuFreebsd);
+    using Params = ArmEmuFreebsdParams;

     EmuFreebsd(const Params &p) : SEWorkload(p) {}

diff --git a/src/arch/arm/interrupts.hh b/src/arch/arm/interrupts.hh
index ce28879..aba39cd 100644
--- a/src/arch/arm/interrupts.hh
+++ b/src/arch/arm/interrupts.hh
@@ -73,8 +73,7 @@
     uint64_t intStatus;

   public:
-
-    PARAMS(ArmInterrupts);
+    using Params = ArmInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p)
     {

diff --git a/src/arch/arm/linux/se_workload.hhb/src/arch/arm/linux/se_workload.hh

index 1473803..6156661 100644
--- a/src/arch/arm/linux/se_workload.hh
+++ b/src/arch/arm/linux/se_workload.hh
@@ -40,7 +40,8 @@
 class EmuLinux : public SEWorkload
 {
   public:
-    PARAMS(ArmEmuLinux);
+    using Params = ArmEmuLinuxParams;
+
     EmuLinux(const Params &p) : SEWorkload(p) {}

     struct BaseSyscallABI {};
diff --git a/src/arch/arm/nativetrace.hh b/src/arch/arm/nativetrace.hh
index 84d835d..14ab303 100644
--- a/src/arch/arm/nativetrace.hh
+++ b/src/arch/arm/nativetrace.hh
@@ -96,7 +96,7 @@
     bool stopOnPCError;

   public:
-    PARAMS(ArmNativeTrace);
+    using Params = ArmNativeTraceParams;

     ArmNativeTrace(const Params &p) :
         NativeTrace(p), stopOnPCError(p.stop_on_pc_error)
diff --git a/src/arch/arm/se_workload.hh b/src/arch/arm/se_workload.hh
index 8f6b639..70a85b0 100644
--- a/src/arch/arm/se_workload.hh
+++ b/src/arch/arm/se_workload.hh
@@ -38,7 +38,8 @@
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(ArmSEWorkload);
+    using Params = ArmSEWorkloadParams;
+
     SEWorkload(const Params &p) : ::SEWorkload(p) {}

     ::Loader::Arch getArch() const override { return ::Loader::Arm64; }
diff --git a/src/arch/arm/tlb.hh b/src/arch/arm/tlb.hh
index d71df7e..e06939e 100644
--- a/src/arch/arm/tlb.hh
+++ b/src/arch/arm/tlb.hh
@@ -204,7 +204,7 @@

int rangeMRU; //On lookup, only move entries ahead when outsiderangeMRU


   public:
-    PARAMS(ArmTLB);
+    using Params = ArmTLBParams;
     TLB(const Params &p);
     TLB(const Params &p, int _size, TableWalker *_walker);

diff --git a/src/arch/generic/interrupts.hh b/src/arch/generic/interrupts.hh
index e1eab1b..a4c640f 100644
--- a/src/arch/generic/interrupts.hh
+++ b/src/arch/generic/interrupts.hh
@@ -41,7 +41,7 @@
     ThreadContext *tc = nullptr;

   public:
-    PARAMS(BaseInterrupts);
+    using Params = BaseInterruptsParams;

     BaseInterrupts(const Params &p) : SimObject(p) {}

diff --git a/src/arch/mips/interrupts.hh b/src/arch/mips/interrupts.hh
index 418ec42..ebfc420 100644
--- a/src/arch/mips/interrupts.hh
+++ b/src/arch/mips/interrupts.hh
@@ -47,7 +47,7 @@
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(MipsInterrupts);
+    using Params = MipsInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p) {}

diff --git a/src/arch/mips/isa.hh b/src/arch/mips/isa.hh
index 7ab1fa1..1e94a98 100644
--- a/src/arch/mips/isa.hh
+++ b/src/arch/mips/isa.hh
@@ -54,7 +54,7 @@
         // The MIPS name for this file is CP0 or Coprocessor 0
         typedef ISA CP0;

-        PARAMS(MipsISA);
+        using Params = MipsISAParams;

       protected:
         // Number of threads and vpes an individual ISA state can handle

diff --git a/src/arch/mips/linux/se_workload.hhb/src/arch/mips/linux/se_workload.hh

index 2a21c7c..13e2110 100644
--- a/src/arch/mips/linux/se_workload.hh
+++ b/src/arch/mips/linux/se_workload.hh
@@ -44,7 +44,7 @@
     static SyscallDescTable<SyscallABI> syscallDescs;

   public:
-    PARAMS(MipsEmuLinux);
+    using Params = MipsEmuLinuxParams;

     EmuLinux(const Params &p) : SEWorkload(p) {}

diff --git a/src/arch/mips/se_workload.hh b/src/arch/mips/se_workload.hh
index 18e054b..55c605d 100644
--- a/src/arch/mips/se_workload.hh
+++ b/src/arch/mips/se_workload.hh
@@ -40,7 +40,7 @@
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(MipsSEWorkload);
+    using Params = MipsSEWorkloadParams;

     SEWorkload(const Params &p) : ::SEWorkload(p) {}

diff --git a/src/arch/power/interrupts.hh b/src/arch/power/interrupts.hh
index 91f2dc3..f5d571d 100644
--- a/src/arch/power/interrupts.hh
+++ b/src/arch/power/interrupts.hh
@@ -41,7 +41,7 @@
 class Interrupts : public BaseInterrupts
 {
   public:
-    PARAMS(PowerInterrupts);
+    using Params = PowerInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p) {}

diff --git a/src/arch/power/isa.hh b/src/arch/power/isa.hh
index d3f527b..076cbc8 100644
--- a/src/arch/power/isa.hh
+++ b/src/arch/power/isa.hh
@@ -52,8 +52,6 @@
     RegVal miscRegs[NumMiscRegs];

   public:
-    PARAMS(PowerISA);
-
     void clear() {}

   public:
@@ -128,7 +126,7 @@
         return reg;
     }

-    const Params &params() const;
+    using Params = PowerISAParams;

     ISA(const Params &p);
 };

diff --git a/src/arch/power/linux/se_workload.hhb/src/arch/power/linux/se_workload.hh

index 1886f7c..d8012ff 100644
--- a/src/arch/power/linux/se_workload.hh
+++ b/src/arch/power/linux/se_workload.hh
@@ -45,7 +45,7 @@
     static SyscallDescTable<SEWorkload::SyscallABI> syscallDescs;

   public:
-    PARAMS(PowerEmuLinux);
+    using Params = PowerEmuLinuxParams;

     EmuLinux(const Params &p) : SEWorkload(p) {}

diff --git a/src/arch/power/se_workload.hh b/src/arch/power/se_workload.hh
index 6093823..9bdd0cc 100644
--- a/src/arch/power/se_workload.hh
+++ b/src/arch/power/se_workload.hh
@@ -40,7 +40,7 @@
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(PowerSEWorkload);
+    using Params = PowerSEWorkloadParams;
     SEWorkload(const Params &p) : ::SEWorkload(p) {}

     ::Loader::Arch getArch() const override { return ::Loader::Power; }
diff --git a/src/arch/riscv/interrupts.hh b/src/arch/riscv/interrupts.hh
index 375c549..f07e7d7 100644
--- a/src/arch/riscv/interrupts.hh
+++ b/src/arch/riscv/interrupts.hh
@@ -57,7 +57,7 @@
     std::bitset<NumInterruptTypes> ie;

   public:
-    PARAMS(RiscvInterrupts);
+    using Params = RiscvInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p), ip(0), ie(0) {}

diff --git a/src/arch/riscv/isa.hh b/src/arch/riscv/isa.hh
index 1bd64d6..dbcb206 100644
--- a/src/arch/riscv/isa.hh
+++ b/src/arch/riscv/isa.hh
@@ -76,7 +76,7 @@
     bool hpmCounterEnabled(int counter) const;

   public:
-    PARAMS(RiscvISA);
+    using Params = RiscvISAParams;

     void clear();

diff --git a/src/arch/riscv/linux/se_workload.hhb/src/arch/riscv/linux/se_workload.hh

index e6110bb..862d33a 100644
--- a/src/arch/riscv/linux/se_workload.hh
+++ b/src/arch/riscv/linux/se_workload.hh
@@ -49,7 +49,7 @@
     static SyscallDescTable<SEWorkload::SyscallABI> syscallDescs32;

   public:
-    PARAMS(RiscvEmuLinux);
+    using Params = RiscvEmuLinuxParams;

     EmuLinux(const Params &p) : SEWorkload(p) {}

diff --git a/src/arch/riscv/pagetable_walker.hhb/src/arch/riscv/pagetable_walker.hh

index 514ea3b..1291284 100644
--- a/src/arch/riscv/pagetable_walker.hh
+++ b/src/arch/riscv/pagetable_walker.hh
@@ -191,7 +191,7 @@
             tlb = _tlb;
         }

-        PARAMS(RiscvPagetableWalker);
+        using Params = RiscvPagetableWalkerParams;

         Walker(const Params &params) :
             ClockedObject(params), port(name() + ".port", this),
diff --git a/src/arch/riscv/se_workload.hh b/src/arch/riscv/se_workload.hh
index 20f108f..fcb79e8 100644
--- a/src/arch/riscv/se_workload.hh
+++ b/src/arch/riscv/se_workload.hh
@@ -40,7 +40,7 @@
 class SEWorkload : public ::SEWorkload
 {
   public:
-    PARAMS(RiscvSEWorkload);
+    using Params = RiscvSEWorkloadParams;

     SEWorkload(const Params &p) : ::SEWorkload(p) {}

diff --git a/src/arch/sparc/interrupts.hh b/src/arch/sparc/interrupts.hh
index 7011e84..02708b8 100644
--- a/src/arch/sparc/interrupts.hh
+++ b/src/arch/sparc/interrupts.hh
@@ -61,7 +61,7 @@

   public:

-    PARAMS(SparcInterrupts);
+    using Params = SparcInterruptsParams;

     Interrupts(const Params &p) : BaseInterrupts(p)
     {
diff --git a/src/arch/sparc/isa.hh b/src/arch/sparc/isa.hh
index f7bd2e7..f7aee9a 100644
--- a/src/arch/sparc/isa.hh
+++ b/src/arch/sparc/isa.hh
@@ -215,7 +215,7 @@
     int flattenCCIndex(int reg) const { return reg; }
     int flattenMiscIndex(int reg) const { return reg; }

-    PARAMS(SparcISA);
+    using Params = SparcISAParams;

     ISA(const Params &p);
 };

diff --git a/src/arch/sparc/linux/se_workload.hhb/src/arch/sparc/linux/se_workload.hh

index 5e10b4f..1a0afef 100644
--- a/src/arch/sparc/linux/se_workload.hh
+++ b/src/arch/sparc/linux/se_workload.hh
@@ -50,7 +50,7 @@
     void syscall32(ThreadContext *tc);

   public:
-    PARAMS(SparcEmuLinux);
+    using Params = SparcEmuLinuxParams;

     EmuLinux(const Params &p);

diff --git a/src/arch/x86/fs_workload.hh b/src/arch/x86/fs_workload.hh
index 4cb996d1..f926dce 100644
--- a/src/arch/x86/fs_workload.hh
+++ b/src/arch/x86/fs_workload.hh
@@ -71,7 +71,7 @@
 class FsWorkload : public KernelWorkload
 {
   public:
-    PARAMS(X86FsWorkload);
+    using Params = X86FsWorkloadParams;
     FsWorkload(const Params &p);

   public:
diff --git a/src/arch/x86/interrupts.hh b/src/arch/x86/interrupts.hh
index b5cfc41..79a959a 100644
--- a/src/arch/x86/interrupts.hh
+++ b/src/arch/x86/interrupts.hh
@@ -190,7 +190,7 @@
     /*
      * Params stuff.
      */
-    PARAMS(X86LocalApic);
+    using Params = X86LocalApicParams;

     void setThreadContext(ThreadContext *_tc) override;

diff --git a/src/arch/x86/isa.hh b/src/arch/x86/isa.hh
index 7e72781..8bd3072 100644
--- a/src/arch/x86/isa.hh
+++ b/src/arch/x86/isa.hh
@@ -57,7 +57,7 @@
       public:
         void clear();

-        PARAMS(X86ISA);
+        using Params = X86ISAParams;

         ISA(const Params &p);

diff --git a/src/arch/x86/linux/se_workload.hhb/src/arch/x86/linux/se_workload.hh

index f2f02f2..b8d1774 100644
--- a/src/arch/x86/linux/se_workload.hh
+++ b/src/arch/x86/linux/se_workload.hh
@@ -52,7 +52,7 @@
 class EmuLinux : public SEWorkload
 {
   public:
-    PARAMS(X86EmuLinux);
+    using Params = X86EmuLinuxParams;

     EmuLinux(const Params &p);

diff --git a/src/arch/x86/pagetable_walker.hhb/src/arch/x86/pagetable_walker.hh

index 6a96e58..f66e147 100644
--- a/src/arch/x86/pagetable_walker.hh
+++ b/src/arch/x86/pagetable_walker.hh
@@ -193,7 +193,7 @@
             tlb = _tlb;
         }

-        PARAMS(X86PagetableWalker);
+        using Params = X86PagetableWalkerParams;

         Walker(const Params &params) :
             ClockedObject(params), port(name() + ".port", this),
diff --git a/src/dev/arm/gic_v2.hh b/src/dev/arm/gic_v2.hh
index 9e671be..ef8fd63 100644
--- a/src/dev/arm/gic_v2.hh
+++ b/src/dev/arm/gic_v2.hh
@@ -475,7 +475,7 @@
     int pendingDelayedInterrupts;

   public:
-    PARAMS(GicV2);
+    using Params = GicV2Params;
     GicV2(const Params &p);
     ~GicV2();

diff --git a/src/dev/arm/pl111.hh b/src/dev/arm/pl111.hh
index afa11e9..2a9b93c 100644
--- a/src/dev/arm/pl111.hh
+++ b/src/dev/arm/pl111.hh
@@ -356,7 +356,7 @@
     bool enableCapture;

   public:
-    PARAMS(Pl111);
+    using Params = Pl111Params;
     Pl111(const Params &p);
     ~Pl111();

diff --git a/src/dev/arm/realview.hh b/src/dev/arm/realview.hh
index e51cf6f..75def2f 100644
--- a/src/dev/arm/realview.hh
+++ b/src/dev/arm/realview.hh
@@ -63,7 +63,7 @@
     BaseGic *gic;

   public:
-    PARAMS(RealView);
+    using Params = RealViewParams;

     /**
      * Constructor for the Tsunami Class.
diff --git a/src/dev/arm/rtc_pl031.hh b/src/dev/arm/rtc_pl031.hh
index 3cc1faf..0ca6701 100644
--- a/src/dev/arm/rtc_pl031.hh
+++ b/src/dev/arm/rtc_pl031.hh
@@ -97,7 +97,7 @@
     void resyncMatch();

   public:
-    PARAMS(PL031);
+    using Params = PL031Params;

     /**
       * The constructor for RealView just registers itself with the MMU.
diff --git a/src/dev/arm/timer_a9global.hh b/src/dev/arm/timer_a9global.hh
index 03ef1a8..c56a291 100644
--- a/src/dev/arm/timer_a9global.hh
+++ b/src/dev/arm/timer_a9global.hh
@@ -149,7 +149,7 @@
     Timer global_timer;

   public:
-    PARAMS(A9GlobalTimer);
+    using Params = A9GlobalTimerParams;

     /**
       * The constructor for RealView just registers itself with the MMU.
diff --git a/src/dev/arm/timer_sp804.hh b/src/dev/arm/timer_sp804.hh
index c19d165..0658467 100644
--- a/src/dev/arm/timer_sp804.hh
+++ b/src/dev/arm/timer_sp804.hh
@@ -135,7 +135,7 @@
     Timer timer1;

   public:
-    PARAMS(Sp804);
+    using Params = Sp804Params;

     /**
       * The constructor for RealView just registers itself with the MMU.
diff --git a/src/dev/arm/vgic.hh b/src/dev/arm/vgic.hh
index 29a6b8e..b3af9bb 100644
--- a/src/dev/arm/vgic.hh
+++ b/src/dev/arm/vgic.hh
@@ -186,7 +186,7 @@
     struct std::array<vcpuIntData, VGIC_CPU_MAX>  vcpuData;

   public:
-    PARAMS(VGic);
+    using Params = VGicParams;
     VGic(const Params &p);
     ~VGic();

diff --git a/src/dev/baddev.hh b/src/dev/baddev.hh
index 0f1a65d..835a34e 100644
--- a/src/dev/baddev.hh
+++ b/src/dev/baddev.hh
@@ -49,7 +49,7 @@
     std::string devname;

   public:
-    PARAMS(BadDevice);
+    using Params = BadDeviceParams;

     /**
      * Constructor for the Baddev Class.
diff --git a/src/dev/io_device.hh b/src/dev/io_device.hh
index f86289b..834b505 100644
--- a/src/dev/io_device.hh
+++ b/src/dev/io_device.hh
@@ -128,7 +128,7 @@
     virtual Tick write(PacketPtr pkt) = 0;

   public:
-    PARAMS(PioDevice);
+    using Params = PioDeviceParams;
     PioDevice(const Params &p);
     virtual ~PioDevice();

diff --git a/src/dev/mips/malta_cchip.hh b/src/dev/mips/malta_cchip.hh
index 711663d..82dcad2 100644
--- a/src/dev/mips/malta_cchip.hh
+++ b/src/dev/mips/malta_cchip.hh
@@ -76,7 +76,7 @@
     //uint64_t itint;

   public:
-    PARAMS(MaltaCChip);
+    using Params = MaltaCChipParams;

     /**
      * Initialize the Malta CChip by setting all of the
diff --git a/src/dev/net/dist_etherlink.hh b/src/dev/net/dist_etherlink.hh
index c82b0ab..a3f32d3 100644
--- a/src/dev/net/dist_etherlink.hh
+++ b/src/dev/net/dist_etherlink.hh
@@ -215,7 +215,7 @@
     Tick linkDelay;

   public:
-    PARAMS(DistEtherLink);
+    using Params = DistEtherLinkParams;
     DistEtherLink(const Params &p);
     ~DistEtherLink();

diff --git a/src/dev/net/etherbus.hh b/src/dev/net/etherbus.hh
index 49998ed..e280f2b 100644
--- a/src/dev/net/etherbus.hh
+++ b/src/dev/net/etherbus.hh
@@ -55,7 +55,7 @@
     EtherDump *dump;

   public:
-    PARAMS(EtherBus);
+    using Params = EtherBusParams;
     EtherBus(const Params &p);
     virtual ~EtherBus() {}

diff --git a/src/dev/net/etherdevice.hh b/src/dev/net/etherdevice.hh
index d9b60e5..2126afb 100644
--- a/src/dev/net/etherdevice.hh
+++ b/src/dev/net/etherdevice.hh
@@ -45,7 +45,7 @@
 class EtherDevice : public PciDevice
 {
   public:
-    PARAMS(EtherDevice);
+    using Params = EtherDeviceParams;
     EtherDevice(const Params &params)
         : PciDevice(params),
           etherDeviceStats(this)
@@ -140,7 +140,7 @@
 class EtherDevBase : public EtherDevice
 {
   public:
-    PARAMS(EtherDevBase);
+    using Params = EtherDevBaseParams;
     EtherDevBase(const Params &params)
         : EtherDevice(params)
     {}
diff --git a/src/dev/net/etherlink.hh b/src/dev/net/etherlink.hh
index a15877c..f275366 100644
--- a/src/dev/net/etherlink.hh
+++ b/src/dev/net/etherlink.hh
@@ -140,7 +140,7 @@
     Interface *interface[2];

   public:
-    PARAMS(EtherLink);
+    using Params = EtherLinkParams;
     EtherLink(const Params &p);
     virtual ~EtherLink();

diff --git a/src/dev/net/etherswitch.hh b/src/dev/net/etherswitch.hh
index 9b46f1d..78bcb66 100644
--- a/src/dev/net/etherswitch.hh
+++ b/src/dev/net/etherswitch.hh
@@ -51,7 +51,7 @@
 class EtherSwitch : public SimObject
 {
   public:
-    PARAMS(EtherSwitch);
+    using Params = EtherSwitchParams;

     EtherSwitch(const Params &p);
     ~EtherSwitch();
diff --git a/src/dev/net/ethertap.hh b/src/dev/net/ethertap.hh
index eb4b4be..eb67fa3 100644
--- a/src/dev/net/ethertap.hh
+++ b/src/dev/net/ethertap.hh
@@ -56,7 +56,7 @@
 class EtherTapBase : public SimObject
 {
   public:
-    PARAMS(EtherTapBase);
+    using Params = EtherTapBaseParams;
     EtherTapBase(const Params &p);
     virtual ~EtherTapBase();

@@ -130,7 +130,7 @@
 class EtherTapStub : public EtherTapBase
 {
   public:
-    PARAMS(EtherTapStub);
+    using Params = EtherTapStubParams;
     EtherTapStub(const Params &p);
     ~EtherTapStub();

@@ -159,7 +159,7 @@
 class EtherTap : public EtherTapBase
 {
   public:
-    PARAMS(EtherTap);
+    using Params = EtherTapParams;
     EtherTap(const Params &p);
     ~EtherTap();

diff --git a/src/dev/serial/uart.hh b/src/dev/serial/uart.hh
index 97f0250..770e7a0 100644
--- a/src/dev/serial/uart.hh
+++ b/src/dev/serial/uart.hh
@@ -51,7 +51,7 @@
     SerialDevice *device;

   public:
-    PARAMS(Uart);
+    using Params = UartParams;
     Uart(const Params &p, Addr pio_size);

     /**
diff --git a/src/dev/serial/uart8250.hh b/src/dev/serial/uart8250.hh
index 2525eaa..328924b 100644
--- a/src/dev/serial/uart8250.hh
+++ b/src/dev/serial/uart8250.hh
@@ -209,7 +209,7 @@
     EventFunctionWrapper rxIntrEvent;

   public:
-    PARAMS(Uart8250);
+    using Params = Uart8250Params;
     Uart8250(const Params &p);

     Tick read(PacketPtr pkt) override;
diff --git a/src/dev/sparc/dtod.hh b/src/dev/sparc/dtod.hh
index defe4a0..deb39f1 100644
--- a/src/dev/sparc/dtod.hh
+++ b/src/dev/sparc/dtod.hh
@@ -49,7 +49,7 @@
     uint64_t todTime;

   public:
-    PARAMS(DumbTOD);
+    using Params = DumbTODParams;
     DumbTOD(const Params &p);

     Tick read(PacketPtr pkt) override;
diff --git a/src/dev/sparc/mm_disk.hh b/src/dev/sparc/mm_disk.hh
index 0e111c6..645f346 100644
--- a/src/dev/sparc/mm_disk.hh
+++ b/src/dev/sparc/mm_disk.hh
@@ -47,7 +47,7 @@
     uint8_t diskData[SectorSize];

   public:
-    PARAMS(MmDisk);
+    using Params = MmDiskParams;
     MmDisk(const Params &p);

     Tick read(PacketPtr pkt) override;
diff --git a/src/dev/x86/i8042.hh b/src/dev/x86/i8042.hh
index f707558..1cde2cd 100644
--- a/src/dev/x86/i8042.hh
+++ b/src/dev/x86/i8042.hh
@@ -117,7 +117,7 @@
     uint8_t readDataOut();

   public:
-    PARAMS(I8042);
+    using Params = I8042Params;

     I8042(const Params &p);

diff --git a/src/dev/x86/i82094aa.hh b/src/dev/x86/i82094aa.hh
index f8036f7..1b8a25f 100644
--- a/src/dev/x86/i82094aa.hh
+++ b/src/dev/x86/i82094aa.hh
@@ -85,7 +85,7 @@
     IntRequestPort<I82094AA> intRequestPort;

   public:
-    PARAMS(I82094AA);
+    using Params = I82094AAParams;

     I82094AA(const Params &p);

diff --git a/src/dev/x86/i8237.hh b/src/dev/x86/i8237.hh
index 3aecd92..fbc30f7 100644
--- a/src/dev/x86/i8237.hh
+++ b/src/dev/x86/i8237.hh
@@ -92,7 +92,7 @@
     void setMaskBit(Register &reg, const uint8_t &command);

   public:
-    PARAMS(I8237);
+    using Params = I8237Params;

     I8237(const Params &p);

diff --git a/src/dev/x86/i8254.hh b/src/dev/x86/i8254.hh
index f99ab6d..79e701f 100644
--- a/src/dev/x86/i8254.hh
+++ b/src/dev/x86/i8254.hh
@@ -66,7 +66,7 @@
     void counterInterrupt(unsigned int num);

   public:
-    PARAMS(I8254);
+    using Params = I8254Params;

     Port &
     getPort(const std::string &if_name, PortID idx=InvalidPortID) override
diff --git a/src/dev/x86/i8259.hh b/src/dev/x86/i8259.hh
index 0accf3f..8b024ba 100644
--- a/src/dev/x86/i8259.hh
+++ b/src/dev/x86/i8259.hh
@@ -81,7 +81,7 @@
     void handleEOI(int line);

   public:
-    PARAMS(I8259);
+    using Params = I8259Params;

     I8259(const Params &p);

diff --git a/src/dev/x86/south_bridge.hh b/src/dev/x86/south_bridge.hh
index 921760e..99d8f35 100644
--- a/src/dev/x86/south_bridge.hh
+++ b/src/dev/x86/south_bridge.hh
@@ -55,7 +55,7 @@
     X86ISA::I82094AA * ioApic;

   public:
-    PARAMS(SouthBridge);
+    using Params = SouthBridgeParams;
     SouthBridge(const Params &p);
 };

diff --git a/src/dev/x86/speaker.hh b/src/dev/x86/speaker.hh
index 047856e..7189359 100644
--- a/src/dev/x86/speaker.hh
+++ b/src/dev/x86/speaker.hh
@@ -54,7 +54,7 @@
     I8254 * timer;

   public:
-    PARAMS(PcSpeaker);
+    using Params = PcSpeakerParams;

     Speaker(const Params &p) : BasicPioDevice(p, 1),
         latency(p.pio_latency), controlVal(0), timer(p.i8254)
diff --git a/src/gpu-compute/lds_state.hh b/src/gpu-compute/lds_state.hh
index de29654..0daa840 100644
--- a/src/gpu-compute/lds_state.hh
+++ b/src/gpu-compute/lds_state.hh
@@ -259,7 +259,7 @@
                        unsigned *numBankAccesses);

   public:
-    PARAMS(LdsState);
+    using Params = LdsStateParams;

     LdsState(const Params &params);

diff --git a/src/mem/comm_monitor.hh b/src/mem/comm_monitor.hh
index 557b1df..03f6590 100644
--- a/src/mem/comm_monitor.hh
+++ b/src/mem/comm_monitor.hh
@@ -63,7 +63,7 @@
   public: // Construction & SimObject interfaces

     /** Parameters of communication monitor */
-    PARAMS(CommMonitor);
+    using Params = CommMonitorParams;

     /**
      * Constructor based on the Python params
diff --git a/src/mem/mem_checker_monitor.hh b/src/mem/mem_checker_monitor.hh
index 9ff14c7..a1d5fd3 100644
--- a/src/mem/mem_checker_monitor.hh
+++ b/src/mem/mem_checker_monitor.hh
@@ -52,7 +52,7 @@
   public:

     /** Parameters of memchecker monitor */
-    PARAMS(MemCheckerMonitor);
+    using Params = MemCheckerMonitorParams;

     /**
      * Constructor based on the Python params
diff --git a/src/mem/qos/policy_pf.hh b/src/mem/qos/policy_pf.hh
index d922792..230a3c9 100644
--- a/src/mem/qos/policy_pf.hh
+++ b/src/mem/qos/policy_pf.hh
@@ -58,7 +58,7 @@
  */
 class PropFairPolicy : public Policy
 {
-    PARAMS(QoSPropFairPolicy);
+    using Params = QoSPropFairPolicyParams;

   public:
     PropFairPolicy(const Params &);

diff --git a/src/mem/ruby/network/fault_model/FaultModel.hhb/src/mem/ruby/network/fault_model/FaultModel.hh

index 1de869f..42759ad 100644
--- a/src/mem/ruby/network/fault_model/FaultModel.hh
+++ b/src/mem/ruby/network/fault_model/FaultModel.hh
@@ -53,7 +53,7 @@
 class FaultModel : public SimObject
 {
   public:
-    PARAMS(FaultModel);
+    using Params = FaultModelParams;
     FaultModel(const Params &p);

/************************************************************************/

diff --git a/src/sim/clocked_object.hh b/src/sim/clocked_object.hh
index 12204c3..23ace92 100644
--- a/src/sim/clocked_object.hh
+++ b/src/sim/clocked_object.hh
@@ -234,7 +234,7 @@
     ClockedObject(const ClockedObjectParams &p);

     /** Parameters of ClockedObject */
-    PARAMS(ClockedObject);
+    using Params = ClockedObjectParams;

     void serialize(CheckpointOut &cp) const override;
     void unserialize(CheckpointIn &cp) override;
diff --git a/src/sim/se_workload.hh b/src/sim/se_workload.hh
index dc3a3d3..50c35dd 100644
--- a/src/sim/se_workload.hh
+++ b/src/sim/se_workload.hh
@@ -34,7 +34,7 @@
 class SEWorkload : public Workload
 {
   public:
-    PARAMS(SEWorkload);
+    using Params = SEWorkloadParams;

     SEWorkload(const Params &p);


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/41613

To unsubscribe, or for help writing mail filters, visithttps://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id71829aca71341d46964d8f071099342b946b62f
Gerrit-Change-Number: 41613
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-MessageType: newchange

_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: misc: Remove unused params() definitions

Reply via email to