Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/42743 )
Change subject: cpu: Delete unnecessary create() methods.
......................................................................
cpu: Delete unnecessary create() methods.
These were added in changes which were created before create() methods
were mostly automated, but were checked in after the then unnecessary
create() methods were purged.
Change-Id: I03da797ae8328fab6ef6b85dbc4ea86b34512fd5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42743
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/testers/gpu_ruby_test/cpu_thread.cc
M src/cpu/testers/gpu_ruby_test/dma_thread.cc
M src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc
M src/cpu/testers/gpu_ruby_test/protocol_tester.cc
4 files changed, 0 insertions(+), 24 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/testers/gpu_ruby_test/cpu_thread.cc
b/src/cpu/testers/gpu_ruby_test/cpu_thread.cc
index fa801b3..d0ac10e 100644
--- a/src/cpu/testers/gpu_ruby_test/cpu_thread.cc
+++ b/src/cpu/testers/gpu_ruby_test/cpu_thread.cc
@@ -43,12 +43,6 @@
assert(numLanes == 1);
}
-CpuThread*
-CpuThreadParams::create() const
-{
- return new CpuThread(*this);
-}
-
void
CpuThread::issueLoadOps()
{
diff --git a/src/cpu/testers/gpu_ruby_test/dma_thread.cc
b/src/cpu/testers/gpu_ruby_test/dma_thread.cc
index 254158d..e5f79c9 100644
--- a/src/cpu/testers/gpu_ruby_test/dma_thread.cc
+++ b/src/cpu/testers/gpu_ruby_test/dma_thread.cc
@@ -48,12 +48,6 @@
}
-DmaThread*
-DmaThreadParams::create() const
-{
- return new DmaThread(*this);
-}
-
void
DmaThread::issueLoadOps()
{
diff --git a/src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc
b/src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc
index f2f1343..a90b204 100644
--- a/src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc
+++ b/src/cpu/testers/gpu_ruby_test/gpu_wavefront.cc
@@ -48,12 +48,6 @@
}
-GpuWavefront*
-GpuWavefrontParams::create() const
-{
- return new GpuWavefront(*this);
-}
-
void
GpuWavefront::issueLoadOps()
{
diff --git a/src/cpu/testers/gpu_ruby_test/protocol_tester.cc
b/src/cpu/testers/gpu_ruby_test/protocol_tester.cc
index a8f8408..95e6035 100644
--- a/src/cpu/testers/gpu_ruby_test/protocol_tester.cc
+++ b/src/cpu/testers/gpu_ruby_test/protocol_tester.cc
@@ -357,9 +357,3 @@
return true;
}
-
-ProtocolTester*
-ProtocolTesterParams::create() const
-{
- return new ProtocolTester(*this);
-}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42743
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v21-0
Gerrit-Change-Id: I03da797ae8328fab6ef6b85dbc4ea86b34512fd5
Gerrit-Change-Number: 42743
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
