Giacomo Travaglini has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/42863 )
Change subject: configs: Unnecessary iteration on baremetal.py and
starter_fs.py
......................................................................
configs: Unnecessary iteration on baremetal.py and starter_fs.py
The code is actually wrong and at the moment it works simply because
those scripts are instantiating a single cluster only
Change-Id: Ie756320707f6fdb2039567afd53b966a9386715b
Signed-off-by: Giacomo Travaglini <[email protected]>
---
M configs/example/arm/baremetal.py
M configs/example/arm/starter_fs.py
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/configs/example/arm/baremetal.py
b/configs/example/arm/baremetal.py
index 29e9b48..36cc1c1 100644
--- a/configs/example/arm/baremetal.py
+++ b/configs/example/arm/baremetal.py
@@ -135,8 +135,7 @@
# Create a cache hierarchy for the cluster. We are assuming that
# clusters have core-private L1 caches and an L2 that's shared
# within the cluster.
- for cluster in system.cpu_cluster:
- system.addCaches(want_caches, last_cache_level=2)
+ system.addCaches(want_caches, last_cache_level=2)
# Setup gem5's minimal Linux boot loader.
system.auto_reset_addr = True
diff --git a/configs/example/arm/starter_fs.py
b/configs/example/arm/starter_fs.py
index 9d0f0d2..73d423e 100644
--- a/configs/example/arm/starter_fs.py
+++ b/configs/example/arm/starter_fs.py
@@ -138,8 +138,7 @@
# Create a cache hierarchy for the cluster. We are assuming that
# clusters have core-private L1 caches and an L2 that's shared
# within the cluster.
- for cluster in system.cpu_cluster:
- system.addCaches(want_caches, last_cache_level=2)
+ system.addCaches(want_caches, last_cache_level=2)
# Setup gem5's minimal Linux boot loader.
system.realview.setupBootLoader(system, SysPaths.binary)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42863
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie756320707f6fdb2039567afd53b966a9386715b
Gerrit-Change-Number: 42863
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
