Tiago Mück has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/43043 )
Change subject: scons,mem-ruby: export need_partial_func_reads in SConstruct
......................................................................
scons,mem-ruby: export need_partial_func_reads in SConstruct
need_partial_func_reads should now be modified from protocol specific
files (e.g. src/learning_gem5/part3/SConsopts)
Change-Id: I38039aab6178a019d063d6124200050f2ed7b446
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/43043
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M SConstruct
M src/mem/ruby/system/SConscript
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/SConstruct b/SConstruct
index beaf9ae..fb3421c 100755
--- a/SConstruct
+++ b/SConstruct
@@ -764,6 +764,9 @@
Export('protocol_dirs')
slicc_includes = []
Export('slicc_includes')
+# list of protocols that require the partial functional read interface
+need_partial_func_reads = []
+Export('need_partial_func_reads')
# Walk the tree and execute all SConsopts scripts that wil add to the
# above variables
diff --git a/src/mem/ruby/system/SConscript b/src/mem/ruby/system/SConscript
index a2708ae..e87cd24 100644
--- a/src/mem/ruby/system/SConscript
+++ b/src/mem/ruby/system/SConscript
@@ -45,9 +45,6 @@
env.Append(CPPDEFINES=['PROTOCOL_' + env['PROTOCOL']])
-# list of protocols that require the partial functional read interface
-need_partial_func_reads = []
-
if env['PROTOCOL'] in need_partial_func_reads:
env.Append(CPPDEFINES=['PARTIAL_FUNC_READS'])
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43043
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v21-0
Gerrit-Change-Id: I38039aab6178a019d063d6124200050f2ed7b446
Gerrit-Change-Number: 43043
Gerrit-PatchSet: 2
Gerrit-Owner: Tiago Mück <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Tiago Mück <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
