Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/40868 )

Change subject: scons: Get rid of some unused cruft from Ruby/yacc.
......................................................................

scons: Get rid of some unused cruft from Ruby/yacc.

These variables are never used, and so don't need to be set.

Change-Id: Ia345e3aa12b4437638943a436d28686b6e60acda
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40868
Tested-by: kokoro <[email protected]>
Maintainer: Gabe Black <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Matt Sinclair <[email protected]>
---
M SConstruct
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Matt Sinclair: Looks good to me, but someone else must approve
  Giacomo Travaglini: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/SConstruct b/SConstruct
index beaf9ae..07061f9 100755
--- a/SConstruct
+++ b/SConstruct
@@ -425,10 +425,6 @@
         warning("Don't know how to enable %s sanitizer(s) for your "
                 "compiler." % sanitizers)

-# Set up common yacc/bison flags (needed for Ruby)
-main['YACCFLAGS'] = '-d'
-main['YACCHXXFILESUFFIX'] = '.hh'
-
 # Do this after we save setting back, or else we'll tack on an
 # extra 'qdo' every time we run scons.
 if main['BATCH']:

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40868
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia345e3aa12b4437638943a436d28686b6e60acda
Gerrit-Change-Number: 40868
Gerrit-PatchSet: 13
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to