Giacomo Travaglini has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/43163 )

Change subject: dev: Remove unused console_in from Terminal
......................................................................

dev: Remove unused console_in from Terminal

Change-Id: I4419e03495dadeee87ff167c9be108669f36d267
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
---
M src/dev/serial/terminal.cc
M src/dev/serial/terminal.hh
2 files changed, 0 insertions(+), 41 deletions(-)



diff --git a/src/dev/serial/terminal.cc b/src/dev/serial/terminal.cc
index 2da9c3f..d85cf1f 100644
--- a/src/dev/serial/terminal.cc
+++ b/src/dev/serial/terminal.cc
@@ -283,11 +283,6 @@
     return ret;
 }

-#define MORE_PENDING (1ULL << 61)
-#define RECEIVE_SUCCESS (0ULL << 62)
-#define RECEIVE_NONE (2ULL << 62)
-#define RECEIVE_ERROR (3ULL << 62)
-
 uint8_t
 Terminal::readData()
 {
@@ -302,24 +297,6 @@
     return c;
 }

-uint64_t
-Terminal::console_in()
-{
-    uint64_t value;
-
-    if (dataAvailable()) {
-        value = RECEIVE_SUCCESS | readData();
-        if (!rxbuf.empty())
-            value  |= MORE_PENDING;
-    } else {
-        value = RECEIVE_NONE;
-    }
-
-    DPRINTF(TerminalVerbose, "console_in: return: %#x\n", value);
-
-    return value;
-}
-
 void
 Terminal::writeData(uint8_t c)
 {
diff --git a/src/dev/serial/terminal.hh b/src/dev/serial/terminal.hh
index ba93998..31c8ed9 100644
--- a/src/dev/serial/terminal.hh
+++ b/src/dev/serial/terminal.hh
@@ -127,24 +127,6 @@
     uint8_t readData() override;
     void writeData(uint8_t c) override;
     bool dataAvailable() const override { return !rxbuf.empty(); }
-
-  public:
-    /////////////////
-    // OS interface
-
-    // get a character from the terminal in the console specific format
-    // corresponds to GETC:
-    // retval<63:61>
-    //     000: success: character received
-    //     001: success: character received, more pending
-    //     100: failure: no character ready
-    //     110: failure: character received with error
-    //     111: failure: character received with error, more pending
-    // retval<31:0>
-    //     character read from console
-    //
-    // Interrupts are cleared when the buffer is empty.
-    uint64_t console_in();
 };

 #endif // __DEV_TERMINAL_HH__

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43163
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4419e03495dadeee87ff167c9be108669f36d267
Gerrit-Change-Number: 43163
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to