Attention is currently required from: Giacomo Travaglini, Gabe Black.
Hello kokoro, Giacomo Travaglini, Gabe Black,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/43239
to review the following change.
Change subject: base: Adding static constexpr keywords to log2i
......................................................................
base: Adding static constexpr keywords to log2i
Aligning to the rest of the file
Change-Id: If1e2d120f77843f8fdd4838fdb806a804236e58a
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42543
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/intmath.hh
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/base/intmath.hh b/src/base/intmath.hh
index 85ee525..ff5753d 100644
--- a/src/base/intmath.hh
+++ b/src/base/intmath.hh
@@ -155,7 +155,7 @@
*
* @ingroup api_base_utils
*/
-inline int
+static constexpr int
log2i(int value)
{
assert(isPowerOf2(value) && value > 0);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/43239
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v21-0
Gerrit-Change-Id: If1e2d120f77843f8fdd4838fdb806a804236e58a
Gerrit-Change-Number: 43239
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Yuen <petery....@huawei.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-Attention: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Attention: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
