Kelly Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39616 )
Change subject: mem: Unclear MemoryAccess debug message
......................................................................
mem: Unclear MemoryAccess debug message
This commit removes two excessive printf() arguments that were making
the output of the MemoryAccess debug flag unclear.
Jira issue: https://gem5.atlassian.net/browse/GEM5-892
Change-Id: I0317b22082d8cc0025d9f0038fd3599496f40896
Reported-by: Jinzheng Tu
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39616
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
---
M src/mem/abstract_mem.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/abstract_mem.cc b/src/mem/abstract_mem.cc
index a3e4db8..999ad0f 100644
--- a/src/mem/abstract_mem.cc
+++ b/src/mem/abstract_mem.cc
@@ -349,7 +349,7 @@
DPRINTF(MemoryAccess, "%s from %s of size %i on address %#x data "
"%#x %c\n", label, sys->getRequestorName(pkt->req->
requestorId()), size, pkt->getAddr(),
- size, pkt->getAddr(), pkt->getUintX(byte_order),
+ pkt->getUintX(byte_order),
pkt->req->isUncacheable() ? 'U' : 'C');
return;
}
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39616
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0317b22082d8cc0025d9f0038fd3599496f40896
Gerrit-Change-Number: 39616
Gerrit-PatchSet: 4
Gerrit-Owner: Kelly Nguyen <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Kelly Nguyen <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s