Yep, that would be great. Thanks! Gabe
On Wed, Mar 31, 2021 at 1:27 AM Giacomo Travaglini < giacomo.travagl...@arm.com> wrote: > Hi Gabe, > > Apologies for the late reply; I was on vacation. > That is not a "problem" in testlib. It happens when regressions are > aborted by external forces (e.g. a timeout in Jenkins/kokoro); then the > time field > of metadata doesn't get populated. > > We should probably fix this by initializing time to zero, letting other > logic to signal the failure > > Kind Regards > > Giacomo > > > -----Original Message----- > > From: Gabe Black via gem5-dev <gem5-dev@gem5.org> > > Sent: 29 March 2021 05:40 > > To: gem5 Developer List <gem5-dev@gem5.org> > > Cc: Gabe Black <gabe.bl...@gmail.com> > > Subject: [gem5-dev] More unreproducible kokoro failures... testlib bug? > > > > Hi folks. I have another change which is failing kokoro unreproducibly, > this > > time it seems because of a failure in the test library. I've looked at > the code in > > question and have some weak theories, but nothing which really helps > > identify the problem or a fix. This is especially hard since the failure > doesn't > > reproduce locally. > > > > https://source.cloud.google.com/results/invocations/7a3203b0-f429-48f8- > > b49e-0abf9413cc3c/targets/gem5%2Fgcp_ubuntu%2Fpresubmit/log > > > > > > Traceback (most recent call last): > > File "./main.py", line 25, in <module> > > sys.exit(testlib()) > > File "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/main.py", > line > > 331, in main > > result = globals()['do_'+configuration.config.command]() > > File "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/main.py", > line > > 303, in do_run > > return run_schedule(test_schedule, log_handler) > > File "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/main.py", > line > > 277, in run_schedule > > log_handler.finish_testing() > > File "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/main.py", > line > > 68, in finish_testing > > self.result_handler.close() > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/handlers.py", > > line 164, in close > > self._save() > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/handlers.py", > > line 156, in _save > > result.JUnitSavedResults.save( > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/result.py", line > > 330, in save > > results = JUnitTestSuites(results) > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/result.py", line > > 238, in __init__ > > self.elements.append(JUnitTestSuite(suite)) > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/result.py", line > > 264, in __init__ > > self.elements.append(JUnitTestCase(test)) > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/result.py", line > > 277, in __init__ > > XMLAttribute('time', str(test_result.time["user_time"])), > > File > "/tmpfs/src/git/jenkins-gem5-prod/tests/../ext/testlib/result.py", line > > 77, in time > > return self._metadata.time > > AttributeError: 'TestCaseMetadata' object has no attribute 'time' > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. >
_______________________________________________ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
