Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/44031 )
Change subject: sim,base: Get rid of the system/gdb "breakpoint" methods.
......................................................................
sim,base: Get rid of the system/gdb "breakpoint" methods.
This unused pair of methods could be used to trigger a breakpoint within
the remote GDB stub, but was unused and would need to be called from an
instance of GDB attached to gem5 itself.
The system's version of breakpoint was also limitted in that it would
only cause a breakpoint in the first thread's GDB and no other.
Change-Id: I53ceab78667610177dbb8be1def3a88262befeec
---
M src/base/remote_gdb.hh
M src/sim/system.cc
M src/sim/system.hh
3 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/src/base/remote_gdb.hh b/src/base/remote_gdb.hh
index f45c89f..7d1cbfa 100644
--- a/src/base/remote_gdb.hh
+++ b/src/base/remote_gdb.hh
@@ -157,7 +157,6 @@
void replaceThreadContext(ThreadContext *_tc) { tc = _tc; }
bool trap(int type);
- bool breakpoint() { return trap(SIGTRAP); }
/** @} */ // end of api_remote_gdb
diff --git a/src/sim/system.cc b/src/sim/system.cc
index c7a3baa..e3924d7 100644
--- a/src/sim/system.cc
+++ b/src/sim/system.cc
@@ -300,16 +300,6 @@
memoryMode = mode;
}
-bool System::breakpoint()
-{
- if (!threads.size())
- return false;
- auto *gdb = threads.thread(0).gdb;
- if (!gdb)
- return false;
- return gdb->breakpoint();
-}
-
ContextID
System::registerThreadContext(ThreadContext *tc, ContextID assigned)
{
diff --git a/src/sim/system.hh b/src/sim/system.hh
index 5c58524..f0eac6a 100644
--- a/src/sim/system.hh
+++ b/src/sim/system.hh
@@ -552,9 +552,6 @@
void workItemEnd(uint32_t tid, uint32_t workid);
- public:
- bool breakpoint();
-
protected:
/**
* Range for memory-mapped m5 pseudo ops. The range will be
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44031
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I53ceab78667610177dbb8be1def3a88262befeec
Gerrit-Change-Number: 44031
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-CC: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s