Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40879 )
Change subject: scons: Eliminate the useless USE_SSE2 flag.
......................................................................
scons: Eliminate the useless USE_SSE2 flag.
This option would set the -msse2 compiler flag to avoid using x87
floating point, but every 64 bit x86 CPU supports sse2, and so sse2 is
enabled by default on compilers targeting it. 32 bit x86 CPUs are
obscure enough that it's not worth preserving this marginally meaningful
option which would only matter for them.
Change-Id: Ib425c261b27f1f74300e714619787d04970065ce
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40879
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M SConstruct
1 file changed, 2 insertions(+), 10 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/SConstruct b/SConstruct
index c8e685f..b99ecdb 100755
--- a/SConstruct
+++ b/SConstruct
@@ -603,13 +603,8 @@
for cb in after_sconsopts_callbacks:
cb()
-sticky_vars.AddVariables(
- BoolVariable('USE_EFENCE', 'Link with Electric Fence malloc debugger',
- False),
- BoolVariable('USE_SSE2',
- 'Compile for SSE2 (-msse2) to get IEEE FP on x86 hosts',
- False),
- )
+sticky_vars.Add(BoolVariable('USE_EFENCE',
+ 'Link with Electric Fence malloc debugger', False))
###################################################
#
@@ -801,9 +796,6 @@
# Save sticky variable settings back to current variables file
sticky_vars.Save(current_vars_file, env)
- if env['USE_SSE2']:
- env.Append(CCFLAGS=['-msse2'])
-
env.Append(CCFLAGS='$CCFLAGS_EXTRA')
env.Append(LINKFLAGS='$LDFLAGS_EXTRA')
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40879
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib425c261b27f1f74300e714619787d04970065ce
Gerrit-Change-Number: 40879
Gerrit-PatchSet: 18
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
