Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/44386 )
Change subject: arch-arm: Add a message to a static_assert in isa.hh.
......................................................................
arch-arm: Add a message to a static_assert in isa.hh.
static_asserts without a message are a c++17 feature.
Change-Id: I9d8b5f5a0d7f9b83784f0480afab0f534a466ee5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44386
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
---
M src/arch/arm/isa.hh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/isa.hh b/src/arch/arm/isa.hh
index 2d2b33a..197350a 100644
--- a/src/arch/arm/isa.hh
+++ b/src/arch/arm/isa.hh
@@ -856,7 +856,8 @@
static void
zeroSveVecRegUpperPart(Elem *v, unsigned eCount)
{
- static_assert(sizeof(Elem) <= sizeof(uint64_t));
+ static_assert(sizeof(Elem) <= sizeof(uint64_t),
+ "Elem type is too large.");
eCount *= (sizeof(uint64_t) / sizeof(Elem));
for (int i = 16 / sizeof(Elem); i < eCount; ++i) {
v[i] = 0;
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44386
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9d8b5f5a0d7f9b83784f0480afab0f534a466ee5
Gerrit-Change-Number: 44386
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
