Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/44405 )
Change subject: cpu-o3: Fix missing overrides
......................................................................
cpu-o3: Fix missing overrides
Fix missing overrides in SimpleTrace.
Change-Id: I82ed2a10c98ea67dde7b99db13c0ad5d9ed96f0f
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44405
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/o3/probe/simple_trace.hh
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/o3/probe/simple_trace.hh
b/src/cpu/o3/probe/simple_trace.hh
index 45f85a9..e73779a 100644
--- a/src/cpu/o3/probe/simple_trace.hh
+++ b/src/cpu/o3/probe/simple_trace.hh
@@ -59,10 +59,14 @@
}
/** Register the probe listeners. */
- void regProbeListeners();
+ void regProbeListeners() override;
/** Returns the name of the trace. */
- const std::string name() const { return ProbeListenerObject::name()
+ ".trace"; }
+ const std::string
+ name() const override
+ {
+ return ProbeListenerObject::name() + ".trace";
+ }
private:
void traceFetch(const O3CPUImpl::DynInstConstPtr& dynInst);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44405
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I82ed2a10c98ea67dde7b99db13c0ad5d9ed96f0f
Gerrit-Change-Number: 44405
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
