Srikant Bharadwaj has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/44287 )
Change subject: mem-garnet: Enable bridge rescheduling for DVFS
......................................................................
mem-garnet: Enable bridge rescheduling for DVFS
The Bridge SimObject, which hosts the CDC and SerDes functionality,
could be woken up out-of-order when changing frequencies in DVFS.
This change ensures there is no packet drop during the transition
times.
Change-Id: I40240dcb3e957217abd2d7ad22cc4f78809f7b49
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44287
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/network/garnet/NetworkBridge.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/network/garnet/NetworkBridge.cc
b/src/mem/ruby/network/garnet/NetworkBridge.cc
index ddb6f4e..db5ee7b 100644
--- a/src/mem/ruby/network/garnet/NetworkBridge.cc
+++ b/src/mem/ruby/network/garnet/NetworkBridge.cc
@@ -257,7 +257,10 @@
t_flit = link_srcQueue->getTopFlit();
DPRINTF(RubyNetwork, "Recieved flit %s\n", *t_flit);
flitisizeAndSend(t_flit);
- return;
}
- assert(!link_srcQueue->getSize());
+
+ // Reschedule in case there is a waiting flit.
+ if (!link_srcQueue->isEmpty()) {
+ scheduleEvent(Cycles(1));
+ }
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44287
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I40240dcb3e957217abd2d7ad22cc4f78809f7b49
Gerrit-Change-Number: 44287
Gerrit-PatchSet: 3
Gerrit-Owner: Srikant Bharadwaj <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jieming Yin <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: Srikant Bharadwaj <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
