Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/44985 )
Change subject: base: Stop "using namespace Debug" in DPRINTF style macros.
......................................................................
base: Stop "using namespace Debug" in DPRINTF style macros.
This is apparently not relied on by anything, and could lead to
surprising name lookups since it's not obvious that name lookup is
different in DPRINTF.
Change-Id: Ic2084ac14b85babe49c9d759575b3b03cb432061
---
M src/base/trace.hh
1 file changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/base/trace.hh b/src/base/trace.hh
index 86dec09..36fcee4 100644
--- a/src/base/trace.hh
+++ b/src/base/trace.hh
@@ -169,14 +169,12 @@
#if TRACING_ON
#define DDUMP(x, data, count) do { \
- using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) \
Trace::getDebugLogger()->dump( \
curTick(), name(), data, count, #x); \
} while (0)
#define DPRINTF(x, ...) do { \
- using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), name(), #x, __VA_ARGS__); \
@@ -184,7 +182,6 @@
} while (0)
#define DPRINTFS(x, s, ...) do { \
- using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
curTick(), s->name(), #x, __VA_ARGS__); \
@@ -192,7 +189,6 @@
} while (0)
#define DPRINTFR(x, ...) do { \
- using namespace Debug; \
if (M5_UNLIKELY(DTRACE(x))) { \
Trace::getDebugLogger()->dprintf_flag( \
(Tick)-1, std::string(), #x, __VA_ARGS__); \
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44985
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic2084ac14b85babe49c9d759575b3b03cb432061
Gerrit-Change-Number: 44985
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
