Boris Shingarov has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40890 )
Change subject: arch-power: Fix precedence of register operands
......................................................................
arch-power: Fix precedence of register operands
When RS and RA are both used as operands by an instruction,
RS takes precedence over RA. In such cases, either both the
register operands are used as sources or RS is a source and
RA is a destination.
This changes the order by giving RS the highest precedence
and will be useful for proper disassembly generation.
Change-Id: If351a03a814653f2f371afa936ec7a5cd4377b3a
Signed-off-by: Sandipan Das <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40890
Reviewed-by: Boris Shingarov <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/power/isa/operands.isa
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Boris Shingarov: Looks good to me, approved
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/power/isa/operands.isa
b/src/arch/power/isa/operands.isa
index 23cf50b..8cb39eb 100644
--- a/src/arch/power/isa/operands.isa
+++ b/src/arch/power/isa/operands.isa
@@ -41,9 +41,9 @@
def operands {{
# General Purpose Integer Reg Operands
- 'Ra': ('IntReg', 'ud', 'RA', 'IsInteger', 1),
- 'Rb': ('IntReg', 'ud', 'RB', 'IsInteger', 2),
- 'Rs': ('IntReg', 'ud', 'RS', 'IsInteger', 3),
+ 'Rs': ('IntReg', 'ud', 'RS', 'IsInteger', 1),
+ 'Ra': ('IntReg', 'ud', 'RA', 'IsInteger', 2),
+ 'Rb': ('IntReg', 'ud', 'RB', 'IsInteger', 3),
'Rt': ('IntReg', 'ud', 'RT', 'IsInteger', 4),
# General Purpose Floating Point Reg Operands
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40890
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If351a03a814653f2f371afa936ec7a5cd4377b3a
Gerrit-Change-Number: 40890
Gerrit-PatchSet: 6
Gerrit-Owner: Sandipan Das <[email protected]>
Gerrit-Reviewer: Boris Shingarov <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
