[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Get rid of the now unused print(Src|Dest)Reg methods.

[Gabe Black (Gerrit) via gem5-dev]

Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/42363 )

Change subject: arch-x86: Get rid of the now unused print(Src|Dest)Reg  
methods.
......................................................................
arch-x86: Get rid of the now unused print(Src|Dest)Reg methods.

These would extract particular numbered source or destination registers
from an instruction and feed them into a printReg method. Now that the
register operands know how to print themselves with printReg directly,
these methods are no longer used.

Change-Id: I4244cb2ee97015f51f4783f377282e2a1db5d69b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42363
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/x86/insts/static_inst.cc
M src/arch/x86/insts/static_inst.hh
2 files changed, 0 insertions(+), 16 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/arch/x86/insts/static_inst.cc  
b/src/arch/x86/insts/static_inst.cc
index 767dc9f..67f7eec 100644
--- a/src/arch/x86/insts/static_inst.cc
+++ b/src/arch/x86/insts/static_inst.cc
@@ -106,20 +106,6 @@
 }

 void
-X86StaticInst::printSrcReg(std::ostream &os, int reg, int size) const
-{
-    if (_numSrcRegs > reg)
-        printReg(os, srcRegIdx(reg), size);
-}
-
-void
-X86StaticInst::printDestReg(std::ostream &os, int reg, int size) const
-{
-    if (_numDestRegs > reg)
-        printReg(os, destRegIdx(reg), size);
-}
-
-void
 X86StaticInst::divideStep(uint64_t dividend, uint64_t divisor,
         uint64_t &quotient, uint64_t &remainder)
 {
diff --git a/src/arch/x86/insts/static_inst.hh  
b/src/arch/x86/insts/static_inst.hh
index d356134..4e0cba2 100644
--- a/src/arch/x86/insts/static_inst.hh
+++ b/src/arch/x86/insts/static_inst.hh
@@ -118,8 +118,6 @@

     std::string generateDisassembly(
             Addr pc, const Loader::SymbolTable *symtab) const override;
-    void printSrcReg(std::ostream &os, int reg, int size) const;
-    void printDestReg(std::ostream &os, int reg, int size) const;

     static void divideStep(uint64_t divident, uint64_t divisor,
             uint64_t &quotient, uint64_t &remainder);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42363
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4244cb2ee97015f51f4783f377282e2a1db5d69b
Gerrit-Change-Number: 42363
Gerrit-PatchSet: 11
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Tong Shen <endlessr...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s