Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45008 )
Change subject: base: Move TRACING_ON check into Flag::tracing().
......................................................................
base: Move TRACING_ON check into Flag::tracing().
Now DTRACE is simply an alias for Debug::x. We should keep it now for
compatibility, but it can be removed over time.
Change-Id: Icda18ff57126328e98e440e3a81bf13caa0c27df
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45008
Tested-by: kokoro <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/base/debug.hh
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/debug.hh b/src/base/debug.hh
index f5bfd91..23d78df 100644
--- a/src/base/debug.hh
+++ b/src/base/debug.hh
@@ -48,6 +48,8 @@
#include <string>
#include <vector>
+#include "base/compiler.hh"
+
namespace Debug {
void breakpoint();
@@ -71,7 +73,7 @@
std::string name() const { return _name; }
std::string desc() const { return _desc; }
- bool tracing() const { return _tracing; }
+ bool tracing() const { return TRACING_ON && _tracing; }
virtual void enable() = 0;
virtual void disable() = 0;
@@ -150,7 +152,7 @@
* @ingroup api_trace
* @{
*/
-#define DTRACE(x) (TRACING_ON && Debug::x)
+#define DTRACE(x) (Debug::x)
/** @} */ // end of api_trace
#endif // __BASE_DEBUG_HH__
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45008
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Icda18ff57126328e98e440e3a81bf13caa0c27df
Gerrit-Change-Number: 45008
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
