Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45387 )
Change subject: dev: Rename CopyEngineReg namespace as copy_engine_reg
......................................................................
dev: Rename CopyEngineReg namespace as copy_engine_reg
As part of recent decisions regarding namespace
naming conventions, all namespaces will be changed
to snake case.
::CopyEngineReg became ::copy_engine_reg.
Change-Id: I8ac5ff272ab6a663a25f245c48827c7ff1b6abc5
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45387
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
---
M src/dev/pci/copy_engine.cc
M src/dev/pci/copy_engine.hh
M src/dev/pci/copy_engine_defs.hh
3 files changed, 9 insertions(+), 7 deletions(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/pci/copy_engine.cc b/src/dev/pci/copy_engine.cc
index 82a2909..74a4dab 100644
--- a/src/dev/pci/copy_engine.cc
+++ b/src/dev/pci/copy_engine.cc
@@ -56,7 +56,7 @@
#include "sim/stats.hh"
#include "sim/system.hh"
-using namespace CopyEngineReg;
+using namespace copy_engine_reg;
CopyEngine::CopyEngine(const Params &p)
: PciDevice(p),
diff --git a/src/dev/pci/copy_engine.hh b/src/dev/pci/copy_engine.hh
index 4a5aca6..59f6e39 100644
--- a/src/dev/pci/copy_engine.hh
+++ b/src/dev/pci/copy_engine.hh
@@ -62,9 +62,9 @@
private:
DmaPort cePort;
CopyEngine *ce;
- CopyEngineReg::ChanRegs cr;
+ copy_engine_reg::ChanRegs cr;
int channelId;
- CopyEngineReg::DmaDesc *curDmaDesc;
+ copy_engine_reg::DmaDesc *curDmaDesc;
uint8_t *copyBuffer;
bool busy;
@@ -149,7 +149,7 @@
} copyEngineStats;
// device registers
- CopyEngineReg::Regs regs;
+ copy_engine_reg::Regs regs;
// Array of channels each one with regs/dma port/etc
std::vector<CopyEngineChannel*> chan;
diff --git a/src/dev/pci/copy_engine_defs.hh
b/src/dev/pci/copy_engine_defs.hh
index 6ac8b48..6fdcd6d 100644
--- a/src/dev/pci/copy_engine_defs.hh
+++ b/src/dev/pci/copy_engine_defs.hh
@@ -30,10 +30,12 @@
* Register and structure descriptions for Intel's I/O AT DMA Engine
*/
#include "base/bitfield.hh"
+#include "base/compiler.hh"
#include "sim/serialize.hh"
-namespace CopyEngineReg {
-
+GEM5_DEPRECATED_NAMESPACE(CopyEngineReg, copy_engine_reg);
+namespace copy_engine_reg
+{
// General Channel independant registers, 128 bytes starting at 0x00
const uint32_t GEN_CHANCOUNT = 0x00;
@@ -232,6 +234,6 @@
};
-} // namespace CopyEngineReg
+} // namespace copy_engine_reg
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45387
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8ac5ff272ab6a663a25f245c48827c7ff1b6abc5
Gerrit-Change-Number: 45387
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
