Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45865 )
Change subject: cpu,fastmodel: Get rid of the getSendFunctional method.
......................................................................
cpu,fastmodel: Get rid of the getSendFunctional method.
Change-Id: Ib901f6a37220357fe9f1863f12ee18daed31a538
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45865
Tested-by: kokoro <[email protected]>
Reviewed-by: Yu-hsin Wang <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/arm/fastmodel/iris/cpu.hh
M src/cpu/base.hh
2 files changed, 0 insertions(+), 17 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve
Yu-hsin Wang: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/fastmodel/iris/cpu.hh
b/src/arch/arm/fastmodel/iris/cpu.hh
index 0baebec..7ae0f7f 100644
--- a/src/arch/arm/fastmodel/iris/cpu.hh
+++ b/src/arch/arm/fastmodel/iris/cpu.hh
@@ -83,12 +83,6 @@
Counter totalInsts() const override;
Counter totalOps() const override { return totalInsts(); }
- PortProxy::SendFunctionalFunc
- getSendFunctional() override
- {
- return [this] (PacketPtr pkt) { evs_base_cpu->sendFunc(pkt); };
- }
-
protected:
sc_core::sc_module *evs;
// Hold casted pointer to *evs.
diff --git a/src/cpu/base.hh b/src/cpu/base.hh
index 6d324da..daa0813 100644
--- a/src/cpu/base.hh
+++ b/src/cpu/base.hh
@@ -174,17 +174,6 @@
virtual Port &getDataPort() = 0;
/**
- * Returns a sendFunctional delegate for use with port proxies.
- */
- virtual PortProxy::SendFunctionalFunc
- getSendFunctional()
- {
- auto port = dynamic_cast<RequestPort *>(&getDataPort());
- assert(port);
- return [port](PacketPtr pkt)->void { port->sendFunctional(pkt); };
- }
-
- /**
* Purely virtual method that returns a reference to the instruction
* port. All subclasses must implement this method.
*
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45865
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib901f6a37220357fe9f1863f12ee18daed31a538
Gerrit-Change-Number: 45865
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
