Daniel Carvalho has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/45400 )
Change subject: arch-x86: Rename X86Macroop namespace as x86_macroop
......................................................................
arch-x86: Rename X86Macroop namespace as x86_macroop
As part of recent decisions regarding namespace
naming conventions, all namespaces will be changed
to snake case.
X86Macroop became x86_macroop.
Ideally, this should probably be moved to inside the
X86ISA namespace, and renamed accordingly, but a macroop
namespace would probably generate a lot of conflicts.
Change-Id: I06bc0f33a4c1d95492df9397d7d70e5316b1b96b
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/45400
Tested-by: kokoro <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/x86/isa/macroop.isa
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/isa/macroop.isa b/src/arch/x86/isa/macroop.isa
index ccd065a..64c75b9 100644
--- a/src/arch/x86/isa/macroop.isa
+++ b/src/arch/x86/isa/macroop.isa
@@ -76,7 +76,8 @@
// Basic instruction class declaration template.
def template MacroDeclare {{
- namespace X86Macroop
+ GEM5_DEPRECATED_NAMESPACE(X86Macroop, x86_macroop);
+ namespace x86_macroop
{
/**
* Static instruction class for "%(mnemonic)s".
@@ -97,7 +98,7 @@
def template MacroDisassembly {{
std::string
- X86Macroop::%(class_name)s::generateDisassembly(
+ x86_macroop::%(class_name)s::generateDisassembly(
Addr pc, const Loader::SymbolTable *symtab) const
{
std::stringstream out;
@@ -113,7 +114,7 @@
// Basic instruction class constructor template.
def template MacroConstructor {{
- X86Macroop::%(class_name)s::%(class_name)s(
+ x86_macroop::%(class_name)s::%(class_name)s(
ExtMachInst machInst, EmulEnv _env)
: %(base_class)s("%(mnemonic)s", machInst, %(num_microops)s,
_env)
{
@@ -190,7 +191,7 @@
self.control_indirect = False
def getAllocator(self, env):
- return "new X86Macroop::%s(machInst, %s)" % \
+ return "new x86_macroop::%s(machInst, %s)" % \
(self.name, env.getAllocator())
def getMnemonic(self):
mnemonic = self.name.lower()
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45400
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I06bc0f33a4c1d95492df9397d7d70e5316b1b96b
Gerrit-Change-Number: 45400
Gerrit-PatchSet: 8
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
