a p has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/46261 )

Change subject: cpu-o3: Prevent SW prefetches from forwarding from STQ
......................................................................

cpu-o3: Prevent SW prefetches from forwarding from STQ

The store-to-load forwarding (STLDF) code will consider a SW prefetch hitting
on an older store as a succesful case of STLDF, which is incorrect as SW
prefetches do not return data, and eventually leads to an assert firing.

Jira Issue: https://gem5.atlassian.net/browse/GEM5-934

Change-Id: I4c26f13642dc0b5101914109288614010f8f9978
---
M src/cpu/o3/lsq_unit.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/cpu/o3/lsq_unit.cc b/src/cpu/o3/lsq_unit.cc
index 22965a9..eb0e1e9 100644
--- a/src/cpu/o3/lsq_unit.cc
+++ b/src/cpu/o3/lsq_unit.cc
@@ -1380,7 +1380,7 @@
     auto store_it = load_inst->sqIt;
     assert (store_it >= storeWBIt);
     // End once we've reached the top of the LSQ
-    while (store_it != storeWBIt) {
+    while (store_it != storeWBIt && !load_inst->isDataPrefetch()) {
         // Move the index to one younger
         store_it--;
         assert(store_it->valid());

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46261
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4c26f13642dc0b5101914109288614010f8f9978
Gerrit-Change-Number: 46261
Gerrit-PatchSet: 1
Gerrit-Owner: a p <arthurper...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to