[gem5-dev] Change in gem5/gem5[develop]: util,systemc: Fix create and params signature

Sun, 06 Jun 2021 17:12:59 -0700

Daniel Carvalho has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/46540 ) 

Change subject: util,systemc: Fix create and params signature
......................................................................

util,systemc: Fix create and params signature

These have been updated in src/, but were forgotten
here.

Change-Id: I19825f3f60d7ccd60282d5e7072c2f4c4959e7d8
Signed-off-by: Daniel R. Carvalho <oda...@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46540
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M util/systemc/systemc_within_gem5/systemc_simple_object/feeder.cc
M util/systemc/systemc_within_gem5/systemc_simple_object/feeder.hh
M util/systemc/systemc_within_gem5/systemc_simple_object/printer.cc
3 files changed, 5 insertions(+), 11 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass
diff --git a/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.cc b/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.cc 
index 008fe4e..7719503 100644
--- a/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.cc
+++ b/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.cc
@@ -29,9 +29,9 @@
 #include "sim/sim_exit.hh"
 #include "systemc_simple_object/feeder.hh"

-Feeder::Feeder(Gem5_FeederParams *params) :
-    SimObject(params), printer(params->printer), delay(params->delay),
-    strings(params->strings), index(0), event(this)
+Feeder::Feeder(const Gem5_FeederParams &params) :
+    SimObject(params), printer(params.printer), delay(params.delay),
+    strings(params.strings), index(0), event(this)
 {
// Bind the printer objects "input" port to our sc_buffer. This will let 
     // us feed it values. If some other object was responsible for the
@@ -59,9 +59,3 @@

     schedule(&event, curTick() + delay);
 }
-
-Feeder *
-Gem5_FeederParams::create()
-{
-    return new Feeder(this);
-}
diff --git a/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.hh b/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.hh 
index d768217..be5b3ff 100644
--- a/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.hh
+++ b/util/systemc/systemc_within_gem5/systemc_simple_object/feeder.hh
@@ -47,7 +47,7 @@
 class Feeder : public SimObject
 {
   public:
-    Feeder(Gem5_FeederParams *params);
+    Feeder(const Gem5_FeederParams &params);

     void feed();
diff --git a/util/systemc/systemc_within_gem5/systemc_simple_object/printer.cc b/util/systemc/systemc_within_gem5/systemc_simple_object/printer.cc 
index 31d3309..4f15372 100644
--- a/util/systemc/systemc_within_gem5/systemc_simple_object/printer.cc
+++ b/util/systemc/systemc_within_gem5/systemc_simple_object/printer.cc
@@ -36,7 +36,7 @@
// systemc object could accept those parameters however it likes, for instance 
 // through its constructor or by assigning them to a member variable.
 Printer *
-SystemC_PrinterParams::create()
+SystemC_PrinterParams::create() const
 {
     Printer *printer = new Printer(name.c_str());
     printer->prefix = prefix;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46540
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings 

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I19825f3f60d7ccd60282d5e7072c2f4c4959e7d8
Gerrit-Change-Number: 46540
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged

_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to