Gabriel Busnot has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/46561 )
Change subject: mem-ruby: Fix RubySystem::functionalRead with partial data
......................................................................
mem-ruby: Fix RubySystem::functionalRead with partial data
Some protocol other than CHI require the read-write and/or read-only and/or
backing-store controller's buffers to be checked if the system is busy.
More details in issue GEM5-1000
Change-Id: I0ad6385ad5a88fc158e68e4c63c540504b817ccb
---
M src/mem/ruby/system/RubySystem.cc
1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/mem/ruby/system/RubySystem.cc
b/src/mem/ruby/system/RubySystem.cc
index 239b652..2129e53 100644
--- a/src/mem/ruby/system/RubySystem.cc
+++ b/src/mem/ruby/system/RubySystem.cc
@@ -657,6 +657,12 @@
// and/or dirty copy of the line might be in a message buffer or the
// network
if (!ctrl_busy.empty() || !bytes.isFull()) {
+ if (ctrl_rw != nullptr)
+ ctrl_rw->functionalReadBuffers(pkt, bytes);
+ for (auto ctrl : ctrl_ro)
+ ctrl->functionalReadBuffers(pkt, bytes);
+ if (ctrl_bs != nullptr)
+ ctrl_bs->functionalReadBuffers(pkt, bytes);
DPRINTF(RubySystem, "Reading from busy controllers and network\n");
for (auto ctrl : ctrl_busy) {
ctrl->functionalRead(line_address, pkt, bytes);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46561
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0ad6385ad5a88fc158e68e4c63c540504b817ccb
Gerrit-Change-Number: 46561
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriel Busnot <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
