Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/46939 )
Change subject: cpu-o3: Removed "Aggressive" SMT scheduling option
......................................................................
cpu-o3: Removed "Aggressive" SMT scheduling option
A comment claimed this to be different from "oldestReady", when in fact
it was not. Removed it for clarity.
Change-Id: Ic66ee9974ddc8d7a01929afabb601473b7ea23ad
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46939
Reviewed-by: Richard Cooper <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/o3/O3CPU.py
M src/cpu/o3/commit.cc
2 files changed, 1 insertion(+), 8 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Richard Cooper: Looks good to me, but someone else must approve
kokoro: Regressions pass
diff --git a/src/cpu/o3/O3CPU.py b/src/cpu/o3/O3CPU.py
index 7cbb568..301b216 100644
--- a/src/cpu/o3/O3CPU.py
+++ b/src/cpu/o3/O3CPU.py
@@ -52,7 +52,7 @@
vals = [ 'Dynamic', 'Partitioned', 'Threshold' ]
class CommitPolicy(ScopedEnum):
- vals = [ 'Aggressive', 'RoundRobin', 'OldestReady' ]
+ vals = [ 'RoundRobin', 'OldestReady' ]
class O3CPU(BaseCPU):
type = 'O3CPU'
diff --git a/src/cpu/o3/commit.cc b/src/cpu/o3/commit.cc
index ce624da..2359c1a 100644
--- a/src/cpu/o3/commit.cc
+++ b/src/cpu/o3/commit.cc
@@ -1444,13 +1444,6 @@
{
if (numThreads > 1) {
switch (commitPolicy) {
-
- case CommitPolicy::Aggressive:
- //If Policy is Aggressive, commit will call
- //this function multiple times per
- //cycle
- return oldestReady();
-
case CommitPolicy::RoundRobin:
return roundRobin();
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46939
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic66ee9974ddc8d7a01929afabb601473b7ea23ad
Gerrit-Change-Number: 46939
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Richard Cooper <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
