Kyle Roarty has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/46241 )
Change subject: arch-x86: Ignore certain syscalls called in ROCm 4
......................................................................
arch-x86: Ignore certain syscalls called in ROCm 4
fdatasync, sigaltstack, and prctl are called by the ROCm 4 stack, but
were unimplemented. Based on testing, we can change these to ignoreFunc
without affecting program correctness.
sched_yield gets changed to ignoreWarnOnceFunc, as it gets called
significantly more in ROCm 4.
Change-Id: I566b1d71d989c54bfc559d5b83790dff73a38b28
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/46241
Tested-by: kokoro <noreply+kok...@google.com>
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
Reviewed-by: Matt Sinclair <mattdsincl...@gmail.com>
Reviewed-by: Matthew Poremba <matthew.pore...@amd.com>
---
M src/arch/x86/linux/syscall_tbl64.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Matt Sinclair: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/linux/syscall_tbl64.cc
b/src/arch/x86/linux/syscall_tbl64.cc
index 8630265..be82437 100644
--- a/src/arch/x86/linux/syscall_tbl64.cc
+++ b/src/arch/x86/linux/syscall_tbl64.cc
@@ -60,7 +60,7 @@
{ 21, "access", ignoreFunc },
{ 22, "pipe", pipeFunc },
{ 23, "select", selectFunc<X86Linux64> },
- { 24, "sched_yield", ignoreFunc },
+ { 24, "sched_yield", ignoreWarnOnceFunc },
{ 25, "mremap", mremapFunc<X86Linux64> },
{ 26, "msync" },
{ 27, "mincore" },
@@ -111,7 +111,7 @@
{ 72, "fcntl", fcntlFunc },
{ 73, "flock" },
{ 74, "fsync" },
- { 75, "fdatasync" },
+ { 75, "fdatasync", ignoreFunc },
{ 76, "truncate", truncateFunc },
{ 77, "ftruncate", ftruncateFunc },
#if defined(SYS_getdents)
@@ -171,7 +171,7 @@
{ 128, "rt_sigtimedwait" },
{ 129, "rt_sigqueueinfo" },
{ 130, "rt_sigsuspend" },
- { 131, "sigaltstack" },
+ { 131, "sigaltstack", ignoreFunc },
{ 132, "utime" },
{ 133, "mknod", mknodFunc },
{ 134, "uselib" },
@@ -197,7 +197,7 @@
{ 154, "modify_ldt" },
{ 155, "pivot_root" },
{ 156, "_sysctl" },
- { 157, "prctl" },
+ { 157, "prctl", ignoreFunc },
{ 158, "arch_prctl", archPrctlFunc },
{ 159, "adjtimex" },
{ 160, "setrlimit", ignoreFunc },
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/46241
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I566b1d71d989c54bfc559d5b83790dff73a38b28
Gerrit-Change-Number: 46241
Gerrit-PatchSet: 5
Gerrit-Owner: Kyle Roarty <kyleroarty1...@gmail.com>
Gerrit-Reviewer: Alex Dutu <alexandru.d...@amd.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Kyle Roarty <kyleroarty1...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
