Javier Garcia has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/47939 )

Change subject: arch-arm: Fixes an error related to HTM error code handling
......................................................................

arch-arm: Fixes an error related to HTM error code handling

Arguments of the function bits(), called in restore method,
are the other way around.

This leads to unnecessary serialization of some transactions when
SGL is used.

Jira Issue: https://gem5.atlassian.net/browse/GEM5-1041

Change-Id: I0748b1cad57bea5527ca585852d183bd75b4c9ef
---
M src/arch/arm/htm.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/arch/arm/htm.cc b/src/arch/arm/htm.cc
index 0062b56..e94e437 100644
--- a/src/arch/arm/htm.cc
+++ b/src/arch/arm/htm.cc
@@ -129,7 +129,7 @@
       case HtmFailureFaultCause::EXPLICIT:
         replaceBits(error_code, 14, 0, tcreason);
         replaceBits(error_code, 16, 1);
-        retry = bits(15, tcreason);
+        retry = bits(tcreason, 15);
         break;
       case HtmFailureFaultCause::MEMORY:
         replaceBits(error_code, 17, 1);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47939
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0748b1cad57bea5527ca585852d183bd75b4c9ef
Gerrit-Change-Number: 47939
Gerrit-PatchSet: 1
Gerrit-Owner: Javier Garcia <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to