Javier Garcia has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/47939 )
Change subject: arch-arm: Fixes an error related to HTM error code handling
......................................................................
arch-arm: Fixes an error related to HTM error code handling
Arguments of the function bits(), called in restore method,
are the other way around.
This leads to wrong retry handling.
Jira Issue: https://gem5.atlassian.net/browse/GEM5-1041
Change-Id: I0748b1cad57bea5527ca585852d183bd75b4c9ef
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/47939
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/htm.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/htm.cc b/src/arch/arm/htm.cc
index 0062b56..e94e437 100644
--- a/src/arch/arm/htm.cc
+++ b/src/arch/arm/htm.cc
@@ -129,7 +129,7 @@
case HtmFailureFaultCause::EXPLICIT:
replaceBits(error_code, 14, 0, tcreason);
replaceBits(error_code, 16, 1);
- retry = bits(15, tcreason);
+ retry = bits(tcreason, 15);
break;
case HtmFailureFaultCause::MEMORY:
replaceBits(error_code, 17, 1);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/47939
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: release-staging-v21-1
Gerrit-Change-Id: I0748b1cad57bea5527ca585852d183bd75b4c9ef
Gerrit-Change-Number: 47939
Gerrit-PatchSet: 3
Gerrit-Owner: Javier Garcia <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Javier Garcia <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
