[gem5-dev] Change in gem5/gem5[develop]: mem,gpu-compute: Stop using the GEM5_NO_DISCARD macro.

[Gabe Black (Gerrit) via gem5-dev]

Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/48509 )

Change subject: mem,gpu-compute: Stop using the GEM5_NO_DISCARD macro.
......................................................................

mem,gpu-compute: Stop using the GEM5_NO_DISCARD macro.

The [[nodiscard]] attribute is now standard, so we can use that
directly.

Change-Id: I57f59935858facb2a15bf4712be4bfd584bf0c7e
---
M src/gpu-compute/compute_unit.hh
M src/mem/cache/base.hh
M src/mem/cache/cache.hh
M src/mem/cache/noncoherent_cache.hh
4 files changed, 4 insertions(+), 4 deletions(-)



diff --git a/src/gpu-compute/compute_unit.hh  
b/src/gpu-compute/compute_unit.hh
index 30ea418..8beba70 100644
--- a/src/gpu-compute/compute_unit.hh
+++ b/src/gpu-compute/compute_unit.hh
@@ -479,7 +479,7 @@
     int32_t
     getRefCounter(const uint32_t dispatchId, const uint32_t wgId) const;

-    GEM5_NO_DISCARD bool sendToLds(GPUDynInstPtr gpuDynInst);
+    [[nodiscard]] bool sendToLds(GPUDynInstPtr gpuDynInst);

     typedef std::unordered_map<Addr, std::pair<int, int>> pageDataStruct;
     pageDataStruct pageAccesses;
diff --git a/src/mem/cache/base.hh b/src/mem/cache/base.hh
index 2afad5f..988a678 100644
--- a/src/mem/cache/base.hh
+++ b/src/mem/cache/base.hh
@@ -808,7 +808,7 @@
      * @param blk Block to invalidate
      * @return A packet with the writeback, can be nullptr
      */
-    GEM5_NO_DISCARD virtual PacketPtr evictBlock(CacheBlk *blk) = 0;
+    [[nodiscard]] virtual PacketPtr evictBlock(CacheBlk *blk) = 0;

     /**
      * Evict a cache block.
diff --git a/src/mem/cache/cache.hh b/src/mem/cache/cache.hh
index b820062..dfc583b 100644
--- a/src/mem/cache/cache.hh
+++ b/src/mem/cache/cache.hh
@@ -137,7 +137,7 @@
     uint32_t handleSnoop(PacketPtr pkt, CacheBlk *blk,
                          bool is_timing, bool is_deferred, bool  
pending_inval);

-    GEM5_NO_DISCARD PacketPtr evictBlock(CacheBlk *blk) override;
+    [[nodiscard]] PacketPtr evictBlock(CacheBlk *blk) override;

     /**
      * Create a CleanEvict request for the given block.
diff --git a/src/mem/cache/noncoherent_cache.hh  
b/src/mem/cache/noncoherent_cache.hh
index 2d3d61f..f01b08c 100644
--- a/src/mem/cache/noncoherent_cache.hh
+++ b/src/mem/cache/noncoherent_cache.hh
@@ -120,7 +120,7 @@
                                bool needs_writable,
                                bool is_whole_line_write) const override;

-    GEM5_NO_DISCARD PacketPtr evictBlock(CacheBlk *blk) override;
+    [[nodiscard]] PacketPtr evictBlock(CacheBlk *blk) override;

   public:
     NoncoherentCache(const NoncoherentCacheParams &p);

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48509
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I57f59935858facb2a15bf4712be4bfd584bf0c7e
Gerrit-Change-Number: 48509
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s