Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48512 )
Change subject: scons: Increase the minimum version of gcc to 7.
......................................................................
scons: Increase the minimum version of gcc to 7.
This was bumped up to 7 by policy, but the SConsctruct was still
enforcing the old minimum of version 5.
Change-Id: I91966f95b18451f880af279dae286119f7b282d6
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48512
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M SConstruct
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/SConstruct b/SConstruct
index ca1bc7b..c980300 100755
--- a/SConstruct
+++ b/SConstruct
@@ -351,8 +351,8 @@
"src/SConscript to support that compiler.")))
if main['GCC']:
- if compareVersions(main['CXXVERSION'], "5") < 0:
- error('gcc version 5 or newer required.\n'
+ if compareVersions(main['CXXVERSION'], "7") < 0:
+ error('gcc version 7 or newer required.\n'
'Installed version:', main['CXXVERSION'])
# Add the appropriate Link-Time Optimization (LTO) flags if
`--with-lto` is
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48512
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I91966f95b18451f880af279dae286119f7b282d6
Gerrit-Change-Number: 48512
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
